[BACKPORT]: Ensure that pair is trivially copyable (#1249) #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IA#1249) trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes NVIDIA#1246 Co-authored-by: Georgy Evtushenko <[email protected]>
miscco
force-pushed
the
backport_pair_fix
branch
from
587c0c3
to
346fa5d
Compare
miscco
added
thrust
jrhemstad
approved these changes
Jan 18, 2024
miscco
removed
the
backport branch/2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible.
This is especially important for thrust::pair as that is used in rmm extensively.
Fixes #1246
Co-authored-by: Georgy Evtushenko [email protected]