Cleanup our __cccl_config
#1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
cleanup_config
branch
from
f9b1c7d
to
bceb3e6
Compare
miscco
force-pushed
the
cleanup_config
branch
3 times, most recently
from
a690ea5
to
065594a
Compare
jrhemstad
reviewed
Jan 31, 2024
| # define _CCCL_DIAG_SUPPRESS_MSVC(str) | ||
| #endif | ||
|
|
||
| // Convenient shortcuts to silence common warnings |
There was a problem hiding this comment.
comment/question: Given we use the system header pragma and silence all warnings from our headers, do we think we need to still silence individual warnings?
There was a problem hiding this comment.
Yes because we test without system header
We want to consolidate our configuration and keep it maintainable. Consequently put the different functionality into individual headers
miscco
force-pushed
the
cleanup_config
branch
from
065594a
to
2418541
Compare
wmaxey
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to consolidate our configuration and keep it maintainable. Consequently put the different functionality into individual headers