-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTX: Add cuda::ptx:cp_async_bulk_*
#1403
Conversation
Not sure if this is going to be caught by CI: the
However, since we compile with
Can we disable this behavior somehow in lit? @miscco |
libcudacxx/test/libcudacxx/cuda/ptx/ptx.cp.reduce.async.bulk.tensor.compile.pass.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I have implemented most of the comments. One comment is addressed in #1359, and one comment (combining the ptx isa guards in the tests) I hope we can punt to a future PR.
libcudacxx/test/libcudacxx/cuda/ptx/ptx.cp.reduce.async.bulk.tensor.compile.pass.cpp
Outdated
Show resolved
Hide resolved
2819ca0
to
3c5f7de
Compare
Add: - cp.async.bulk - cp.async.bulk.tensor - cp.reduce.async.bulk.tensor - cp.async.bulk.wait_group - cp.async.bulk.commit_group -
3c5f7de
to
2f2244f
Compare
Add: - cp.async.bulk - cp.async.bulk.tensor - cp.reduce.async.bulk.tensor - cp.async.bulk.wait_group - cp.async.bulk.commit_group - Co-authored-by: Jake Hemstad <[email protected]> Co-authored-by: Michael Schellenberger Costa <[email protected]>
Add:
Description
closes #1398, #1399, #1400, #1401, #1402
Checklist