Implement tuple interface for cuda vector types #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
vector_types_tuple
branch
from
ed0b53b
to
249b877
Compare
|
Thanks for considering the feature request.
To avoid putting additional overloads of |
The preferred method would indeed be a hidden friend. Its a bit sad, that we need to define the |
miscco
added
feature request
miscco
force-pushed
the
vector_types_tuple
branch
4 times, most recently
from
d7db687
to
fc11825
Compare
griwes
reviewed
Feb 28, 2024
libcudacxx/test/libcudacxx/cuda/tuple/vector_types_tuple_element.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/tuple/vector_types_tuple_size.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__tuple_dir/vector_types.h
Outdated
Show resolved
Hide resolved
This specializes the `std::tuple_size` and `std::tuple_element` traits so that they are usable with cuda vector types. We also provide overloads for `std::get`, which together enables structured bindings support in C++17 onwards. Fixes NVIDIA#1406
…nt need that interface
miscco
force-pushed
the
vector_types_tuple
branch
from
fc11825
to
d3f39e2
Compare
wmaxey
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specializes the
std::tuple_sizeandstd::tuple_elementtraits so that they are usable with cuda vector types.We also provide overloads for
std::get, which together enables structured bindings support in C++17 onwards.Fixes #1406