-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the DeviceSelect::FlaggedIf algorithm #1533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking this up!
Overall. this looks good already. I think we want to add documentation and examples for the newly introduced interfaces and extend test coverage a bit more.
Working on the tests rn - that's why I submitted it as a draft. Well, on the documentation too... :| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the great work! Looks good, just a couple of minor suggestions.
@elstehle I fixed everything except the ps: Need to also extract the in-place API example in an separate executable test. |
c096964
to
47f3a50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just to make sure that in-place overload compiles, I'd like to see its snippet extracted into API test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor nitpicks remaining, otherwise good to go 🚀
Description
This adds the
cub::DeviceSelect::FlaggedIf
algorithm which combines the predicate selection approach ofcub::DeviceSelect::If
and the flag approach ofcub::DeviceSelect::Flagged
.This fixes #1409.
Checklist