Fix __half for older architectures
#1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
libcu++
miscco
changed the title
__half for older architectures
Older architectures do not support all mathematical functions for `__half` For that we provide backfills through a conversion to `float` Fixes nvbug4563212
elstehle
approved these changes
Mar 15, 2024
griwes
approved these changes
Mar 18, 2024
|
GitHub Actions is not permitted to create or approve pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to SM53 not all mathematical functions are implemented for
__halfThis breaks internal testing . We must also properly qualify all functions, otherwise we might get conversion issues.