Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of naked array with 0 elements in sm90 barrier tests. #1546

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Fix usage of naked array with 0 elements in sm90 barrier tests. #1546

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abd210e
Fix usage of naked array with 0 elements
wmaxey Mar 15, 2024
e5f6445
Try to avoid "pointless comparison" warnings
miscco Mar 18, 2024
063f39e
Merge branch 'main' into bugfix/msvc_zero_sized_array
miscco Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions libcudacxx/test/libcudacxx/cuda/barrier/cp_async_bulk_tensor_generic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,17 @@ CUtensorMap map_encode(T *tensor_ptr, const cuda::std::array<uint64_t, num_dims>

// The stride is the number of bytes to traverse from the first element of one row to the next.
// It must be a multiple of 16.
uint64_t stride[num_dims - 1];
constexpr int num_strides = num_dims - 1;
cuda::std::array<uint64_t, num_strides> stride;
uint64_t base_stride = sizeof(T);
for (size_t i = 0; i < num_dims - 1; ++i) {
for (size_t i = 0; i < num_strides; ++i) {
miscco marked this conversation as resolved.
Show resolved Hide resolved
base_stride *= gmem_dims[i];
stride[i] = base_stride;
}

// The distance between elements in units of sizeof(element). A stride of 2
// can be used to load only the real component of a complex-valued tensor, for instance.
uint32_t elem_stride[num_dims]; // = {1, .., 1};
cuda::std::array<uint32_t, num_dims> elem_stride; // = {1, .., 1};
for (size_t i = 0; i < num_dims; ++i) {
miscco marked this conversation as resolved.
Show resolved Hide resolved
elem_stride[i] = 1;
}
Expand All @@ -240,9 +241,9 @@ CUtensorMap map_encode(T *tensor_ptr, const cuda::std::array<uint64_t, num_dims>
num_dims, // cuuint32_t tensorRank,
tensor_ptr, // void *globalAddress,
gmem_dims.data(), // const cuuint64_t *globalDim,
stride, // const cuuint64_t *globalStrides,
stride.data(), // const cuuint64_t *globalStrides,
smem_dims.data(), // const cuuint32_t *boxDim,
elem_stride, // const cuuint32_t *elementStrides,
elem_stride.data(), // const cuuint32_t *elementStrides,
CUtensorMapInterleave::CU_TENSOR_MAP_INTERLEAVE_NONE,
CUtensorMapSwizzle::CU_TENSOR_MAP_SWIZZLE_NONE,
CUtensorMapL2promotion::CU_TENSOR_MAP_L2_PROMOTION_NONE,
Expand Down
Loading