Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing __device__ hint in WarpMergeSort Documentation #1553

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix missing __device__ hint in WarpMergeSort Documentation #1553

merged 2 commits into from
Mar 20, 2024

Conversation

MARD1NO
Copy link
Contributor

@MARD1NO MARD1NO commented Mar 20, 2024 •
edited by miscco
Loading

Description

Fix missing __device__ in WarpMergeSort documentation

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@MARD1NO MARD1NO requested review from a team as code owners March 20, 2024 06:06
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 20, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

miscco
miscco approved these changes Mar 20, 2024
View reviewed changes
cub/cub/warp/warp_merge_sort.cuh Outdated Show resolved Hide resolved
@miscco
Copy link
Collaborator

miscco commented Mar 20, 2024 •
edited
Loading

/ok to test

@MARD1NO @miscco
Update cub/cub/warp/warp_merge_sort.cuh
9d9c0eb 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@miscco
Copy link
Collaborator

miscco commented Mar 20, 2024

/ok to test

@miscco miscco added cub For all items related to CUB doc Documentation-related items. area: docs labels Mar 20, 2024
elstehle
elstehle approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@elstehle elstehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for helping to improve our documentation!

@miscco miscco merged commit 7c53bbd into NVIDIA:main Mar 20, 2024
587 checks passed
@miscco
Copy link
Collaborator

miscco commented Mar 20, 2024

Thanks a lot and congratulations to your first contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@elstehle elstehle elstehle approved these changes

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-codeowners

@gonidelis gonidelis Awaiting requested review from gonidelis

Assignees
No one assigned
Labels
area: docs cub For all items related to CUB doc Documentation-related items.
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MARD1NO @miscco @elstehle