Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect PR changes to determine if subproject builds are needed. #1572

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

alliepiper
Copy link
Collaborator

@alliepiper alliepiper commented Mar 28, 2024

Subprojects: libcudacxx cub thrust

Dependencies:
  - libcudacxx -> cccl
  - cub -> cccl libcudacxx thrust
  - thrust -> cccl libcudacxx cub

Base SHA: e3758cfa45ebde29893a149933efbb7071fac56
HEAD SHA: a7f6ff444ab9fb38000d11ba3a3fef4f292b3df5

Dirty files:
  - .github/actions/compute-matrix/compute-matrix.sh
  - .github/workflows/pr.yml
  - ci/inspect_changes.sh

Modifications in project?
X - non-project files
  - libcudacxx
  - cub
  - thrust

Modifications in project or dependencies?
X - libcudacxx
X - cub
X - thrust

LIBCUDACXX_DIRTY=true
CUB_DIRTY=true
THRUST_DIRTY=true

@alliepiper alliepiper requested review from a team as code owners March 28, 2024 19:14
@alliepiper alliepiper marked this pull request as draft March 28, 2024 19:14
@alliepiper
Copy link
Collaborator Author

The copy-pr-bot doesn't expose base SHA information. I've filled an issue with them to see if they can somehow expose that info to us.

ci/inspect_changes.sh Outdated Show resolved Hide resolved
@alliepiper alliepiper force-pushed the pr-restrict-projects branch 8 times, most recently from fff1723 to a7f6ff4 Compare April 8, 2024 04:08
@alliepiper alliepiper marked this pull request as ready for review April 8, 2024 15:02
@alliepiper alliepiper changed the title [DRAFT] Inspect PR changes to determine if subproject builds are needed. Inspect PR changes to determine if subproject builds are needed. Apr 8, 2024
Comment on lines +57 to +61
if dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; then
return 1
else
return 0
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know who, but I guess there is a way to transform this into a

Suggested change
if dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; then
return 1
else
return 0
fi
return dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; | SOMETHING

ci/inspect_changes.sh Outdated Show resolved Hide resolved
ci/inspect_changes.sh Outdated Show resolved Hide resolved
ci/inspect_changes.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since none of my comments were blocking.

@alliepiper alliepiper enabled auto-merge (squash) April 8, 2024 23:07
@alliepiper alliepiper merged commit 2889c3c into NVIDIA:main Apr 9, 2024
587 checks passed
@alliepiper alliepiper deleted the pr-restrict-projects branch April 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Limit CI execution to only build/test projects that are modified.
3 participants