-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspect PR changes to determine if subproject builds are needed. #1572
Conversation
alliepiper
commented
Mar 28, 2024
•
edited
Loading
edited
c2b3704
to
aed0bd5
Compare
The copy-pr-bot doesn't expose base SHA information. I've filled an issue with them to see if they can somehow expose that info to us. |
fff1723
to
a7f6ff4
Compare
a7f6ff4
to
f8a5f1b
Compare
if dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; then | ||
return 1 | ||
else | ||
return 0 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know who, but I guess there is a way to transform this into a
if dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; then | |
return 1 | |
else | |
return 0 | |
fi | |
return dirty_files | grep -v -E "${subprojs_grep_expr}" | grep -q "."; | SOMETHING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since none of my comments were blocking.