Enable internal use of std::allocator related functionality
#1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
feature request
miscco
force-pushed
the
allocator_support
branch
from
51891a5
to
9100b2f
Compare
miscco
force-pushed
the
allocator_support
branch
from
9100b2f
to
2d3ea4e
Compare
miscco
force-pushed
the
allocator_support
branch
from
2d3ea4e
to
5c401e4
Compare
|
This is massive. Perhaps the PR description should explain more? Also typo in title ("interal"). |
miscco
changed the title
std::allocator related functionalitystd::allocator related functionality
miscco
force-pushed
the
allocator_support
branch
from
5c401e4
to
4eb8f3a
Compare
miscco
force-pushed
the
allocator_support
branch
from
4eb8f3a
to
9e81f76
Compare
griwes
requested changes
Apr 5, 2024
libcudacxx/include/cuda/std/detail/libcxx/include/__memory/allocation_guard.h
Show resolved
Hide resolved
...ory/allocator.traits/allocator.traits.members/select_on_container_copy_construction.pass.cpp
Outdated
Show resolved
Hide resolved
miscco
commented
Apr 5, 2024
miscco
force-pushed
the
allocator_support
branch
2 times, most recently
from
2581353
to
a9596ed
Compare
miscco
force-pushed
the
allocator_support
branch
3 times, most recently
from
987a9dd
to
2338e42
Compare
miscco
force-pushed
the
allocator_support
branch
from
2338e42
to
17bab4c
Compare
Only expose constexpr allocations when they are supported (They are not supported)
miscco
force-pushed
the
allocator_support
branch
from
ce03c5e
to
9c6f328
Compare
|
@griwes can you give this another look? |
griwes
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports all of the allocator related facilities to be usable internally