Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize <memory> #1639

Merged
merged 26 commits into from
Apr 30, 2024
Merged

Modularize <memory> #1639

merged 26 commits into from
Apr 30, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Apr 16, 2024

This modularizes <memory>.

It either drop deprecated or obsolete content or exposes it through the internal header cuda/std/__memory

Notably this also enables internal use of std::unique_ptr. However, it is currently a bit questionable whether this is the right design as it depends on operator::new.

Before exposing the whole header, we should make some decisions on whether we really want to expose it in this form or whether we want to go with some cuda specific extensions.

@miscco miscco requested review from a team as code owners April 16, 2024 13:25
@miscco miscco added feature request New feature or request. libcu++ For all items related to libcu++ labels Apr 16, 2024
@miscco miscco force-pushed the modularize_memory branch 3 times, most recently from afa60ac to f9bfe7f Compare April 18, 2024 06:48
@miscco miscco force-pushed the modularize_memory branch 2 times, most recently from aa10037 to 98ce686 Compare April 25, 2024 11:31
@@ -0,0 +1,235 @@
// -*- C++ -*-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also compressed_pair.h in __mdspan, please unify if possible.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is and I want to burn that part with fire. But today is not that day

@miscco miscco enabled auto-merge (squash) April 30, 2024 06:08
@miscco miscco merged commit 41301ce into NVIDIA:main Apr 30, 2024
587 checks passed
@miscco miscco deleted the modularize_memory branch April 30, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request. libcu++ For all items related to libcu++
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants