-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize <memory>
#1639
Merged
Merged
Modularize <memory>
#1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
feature request
New feature or request.
libcu++
For all items related to libcu++
labels
Apr 16, 2024
miscco
force-pushed
the
modularize_memory
branch
3 times, most recently
from
April 18, 2024 06:48
afa60ac
to
f9bfe7f
Compare
miscco
force-pushed
the
modularize_memory
branch
from
April 19, 2024 08:45
f9bfe7f
to
6e5137b
Compare
miscco
force-pushed
the
modularize_memory
branch
from
April 19, 2024 12:21
6e5137b
to
9742a99
Compare
miscco
force-pushed
the
modularize_memory
branch
from
April 22, 2024 06:51
e57791e
to
3046946
Compare
miscco
force-pushed
the
modularize_memory
branch
from
April 22, 2024 09:44
9fcdf96
to
a1612a5
Compare
miscco
force-pushed
the
modularize_memory
branch
from
April 22, 2024 11:03
a1612a5
to
919b2fa
Compare
miscco
force-pushed
the
modularize_memory
branch
from
April 23, 2024 11:14
36dfdea
to
7508bc6
Compare
miscco
force-pushed
the
modularize_memory
branch
2 times, most recently
from
April 25, 2024 11:31
aa10037
to
98ce686
Compare
miscco
force-pushed
the
modularize_memory
branch
from
April 25, 2024 11:44
98ce686
to
09b4604
Compare
griwes
reviewed
Apr 29, 2024
@@ -0,0 +1,235 @@ | |||
// -*- C++ -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also compressed_pair.h in __mdspan, please unify if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is and I want to burn that part with fire. But today is not that day
wmaxey
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modularizes
<memory>
.It either drop deprecated or obsolete content or exposes it through the internal header
cuda/std/__memory
Notably this also enables internal use of
std::unique_ptr
. However, it is currently a bit questionable whether this is the right design as it depends on operator::new.Before exposing the whole header, we should make some decisions on whether we really want to expose it in this form or whether we want to go with some cuda specific extensions.