Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of result_of in thrust #1705

Merged
merged 2 commits into from
May 6, 2024
Merged

Fix usage of result_of in thrust #1705

merged 2 commits into from
May 6, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented May 6, 2024

result of has been deprecated and we should not use it when possible.

Rather than relying on it use __invoke_of everywhere

Also fix inproper qualification of enalbe_if in cub

miscco added 2 commits May 6, 2024 08:52
@miscco
Do not use deprecated results_of in thrust
335486d 
Rather than that we can just delegate to our `__invoke_of` implementation
@miscco
Properly use global qualification for cuda::std in cub
35e77f6
@miscco miscco requested review from a team as code owners May 6, 2024 06:58
@miscco miscco requested review from elstehle and wmaxey May 6, 2024 06:58
@jrhemstad jrhemstad mentioned this pull request May 6, 2024
Open
1 task
@miscco miscco merged commit bda02da into NVIDIA:main May 6, 2024
404 checks passed
@miscco miscco deleted the fix_result_of_usage_thrust branch May 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miscco @bernhardmgruber @elstehle