Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icpc / denormals #185

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Fix icpc / denormals #185

merged 2 commits into from
Jul 10, 2023

Conversation

gevtushenko
Copy link
Collaborator

Description

closes 4053381

Intel compiler flushes denormals by default, leading to most radix sort tests failing. This PR disables flushing of denormals.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gevtushenko gevtushenko requested a review from miscco July 10, 2023 11:53
miscco
miscco approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment why we add this flag and move the append to the right positon

cub/cmake/CubBuildCompilerTargets.cmake Outdated Show resolved Hide resolved
@gevtushenko gevtushenko merged commit 7a608a6 into NVIDIA:monorepo Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gevtushenko @miscco