Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CUB test overview docs #1867

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

bernhardmgruber
Copy link
Contributor

This PR proposes some improvements the testing overview in CUB's documentation.

@bernhardmgruber bernhardmgruber requested review from a team as code owners June 14, 2024 12:44
@bernhardmgruber bernhardmgruber added the cub For all items related to CUB label Jun 14, 2024
@bernhardmgruber bernhardmgruber enabled auto-merge (squash) June 14, 2024 13:40
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the overview is more complete and clear now!

@@ -19,7 +19,7 @@ This guide is focused on new tests.
.. code-block:: c++

#include <cub/block/block_scan.cuh>
#include <thrust/host_vector.h>
#include "c2h/vector.cuh"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: good catch, thank you!

@bernhardmgruber bernhardmgruber merged commit 1d2dc78 into NVIDIA:main Jun 17, 2024
48 of 49 checks passed
@bernhardmgruber bernhardmgruber deleted the test_docs branch June 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cub For all items related to CUB
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants