Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken links in CUB readme.md #1908

Closed
wants to merge 1 commit into from

Conversation

elstehle
Copy link
Collaborator

Description

Replaces few links that were still linking to nvlabs.github.io/cub.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@elstehle elstehle requested review from a team as code owners June 24, 2024 15:44
@elstehle elstehle added cub For all items related to CUB doc Documentation-related items. labels Jun 24, 2024
Copy link
Contributor

🟨 CI finished in 1h 01m: Pass: 99%/249 | Total: 1d 04h | Avg: 6m 50s | Max: 29m 02s | Hits: 99%/246735
  • 🟨 cub: Pass: 98%/131 | Total: 17h 46m | Avg: 8m 08s | Max: 29m 02s | Hits: 99%/107469

    🔍 cpu: amd64 🔍
      🔍 amd64              Pass:  98%/123 | Total: 17h 12m | Avg:  8m 23s | Max: 29m 02s | Hits:  99%/100653
      🟩 arm64              Pass: 100%/8   | Total: 34m 08s | Avg:  4m 16s | Max:  4m 46s | Hits:  99%/6816  
    🔍 ctk: 12.4 🔍
      🟩 11.1               Pass: 100%/15  | Total:  1h 04m | Avg:  4m 17s | Max: 15m 09s | Hits:  99%/11568 
      🟩 11.8               Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🔍 12.4               Pass:  98%/113 | Total: 16h 28m | Avg:  8m 44s | Max: 29m 02s | Hits:  99%/93345 
    🔍 cudacxx: nvcc12.4 🔍
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s | Hits: 100%/1408  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 04m | Avg:  4m 17s | Max: 15m 09s | Hits:  99%/11568 
      🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🔍 nvcc12.4           Pass:  98%/111 | Total: 16h 20m | Avg:  8m 50s | Max: 29m 02s | Hits:  99%/91937 
    🔍 cudacxx_family: nvcc 🔍
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s | Hits: 100%/1408  
      🔍 nvcc               Pass:  98%/129 | Total: 17h 39m | Avg:  8m 12s | Max: 29m 02s | Hits:  99%/106061
    🟨 cxx
      🟩 Clang9             Pass: 100%/6   | Total: 26m 45s | Avg:  4m 27s | Max:  5m 14s | Hits: 100%/4890  
      🟩 Clang10            Pass: 100%/3   | Total: 15m 16s | Avg:  5m 05s | Max:  5m 08s | Hits: 100%/2562  
      🟩 Clang11            Pass: 100%/4   | Total: 17m 34s | Avg:  4m 23s | Max:  4m 33s | Hits: 100%/3416  
      🟩 Clang12            Pass: 100%/4   | Total: 17m 15s | Avg:  4m 18s | Max:  4m 24s | Hits: 100%/3416  
      🟩 Clang13            Pass: 100%/4   | Total: 17m 17s | Avg:  4m 19s | Max:  4m 23s | Hits: 100%/3416  
      🟩 Clang14            Pass: 100%/4   | Total: 17m 13s | Avg:  4m 18s | Max:  4m 29s | Hits: 100%/3416  
      🟩 Clang15            Pass: 100%/4   | Total: 17m 38s | Avg:  4m 24s | Max:  4m 34s | Hits: 100%/3408  
      🟩 Clang16            Pass: 100%/4   | Total: 17m 35s | Avg:  4m 23s | Max:  4m 26s | Hits: 100%/3408  
      🟨 Clang17            Pass:  96%/26  | Total:  5h 41m | Avg: 13m 07s | Max: 26m 56s | Hits: 100%/21004 
      🟩 GCC6               Pass: 100%/2   | Total:  6m 58s | Avg:  3m 29s | Max:  3m 34s | Hits:  99%/1552  
      🟩 GCC7               Pass: 100%/6   | Total: 22m 49s | Avg:  3m 48s | Max:  4m 26s | Hits:  99%/4893  
      🟩 GCC8               Pass: 100%/6   | Total: 23m 22s | Avg:  3m 53s | Max:  4m 27s | Hits:  99%/4893  
      🟩 GCC9               Pass: 100%/6   | Total: 23m 15s | Avg:  3m 52s | Max:  4m 33s | Hits:  99%/4893  
      🟩 GCC10              Pass: 100%/4   | Total: 17m 02s | Avg:  4m 15s | Max:  4m 18s | Hits:  99%/3416  
      🟩 GCC11              Pass: 100%/7   | Total: 31m 11s | Avg:  4m 27s | Max:  4m 40s | Hits:  99%/5964  
      🟩 GCC12              Pass: 100%/4   | Total: 17m 57s | Avg:  4m 29s | Max:  4m 41s | Hits:  99%/3408  
      🟨 GCC13              Pass:  96%/28  | Total:  5h 42m | Avg: 12m 14s | Max: 29m 02s | Hits:  99%/23004 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 14m 59s | Avg:  4m 59s | Max:  5m 12s | Hits: 100%/2340  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 15m 09s | Avg: 15m 09s | Max: 15m 09s | Hits:  98%/695   
      🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 48s | Avg: 12m 24s | Max: 12m 43s | Hits:  98%/1390  
      🟩 MSVC14.39          Pass: 100%/3   | Total: 38m 13s | Avg: 12m 44s | Max: 13m 27s | Hits:  98%/2085  
    🟨 cxx_family
      🟨 Clang              Pass:  98%/59  | Total:  8h 07m | Avg:  8m 16s | Max: 26m 56s | Hits: 100%/48936 
      🟨 GCC                Pass:  98%/63  | Total:  8h 05m | Avg:  7m 42s | Max: 29m 02s | Hits:  99%/52023 
      🟩 Intel              Pass: 100%/3   | Total: 14m 59s | Avg:  4m 59s | Max:  5m 12s | Hits: 100%/2340  
      🟩 MSVC               Pass: 100%/6   | Total:  1h 18m | Avg: 13m 01s | Max: 15m 09s | Hits:  98%/4170  
    🟨 jobs
      🟩 Build              Pass: 100%/99  | Total:  7h 53m | Avg:  4m 47s | Max: 15m 09s | Hits:  99%/81909 
      🟨 DeviceLaunch       Pass:  87%/8   | Total:  2h 10m | Avg: 16m 20s | Max: 20m 50s | Hits:  99%/5964  
      🟩 GraphCapture       Pass: 100%/8   | Total:  2h 09m | Avg: 16m 12s | Max: 18m 52s | Hits:  99%/6816  
      🟨 HostLaunch         Pass:  87%/8   | Total:  2h 12m | Avg: 16m 36s | Max: 20m 31s | Hits:  99%/5964  
      🟩 TestGPU            Pass: 100%/8   | Total:  3h 19m | Avg: 24m 56s | Max: 29m 02s | Hits:  99%/6816  
    🟨 std
      🟨 11                 Pass:  97%/34  | Total:  4h 20m | Avg:  7m 39s | Max: 29m 02s | Hits:  99%/27687 
      🟨 14                 Pass:  97%/37  | Total:  4h 47m | Avg:  7m 46s | Max: 26m 56s | Hits:  99%/29772 
      🟩 17                 Pass: 100%/36  | Total:  4h 47m | Avg:  7m 59s | Max: 26m 04s | Hits:  99%/29857 
      🟩 20                 Pass: 100%/24  | Total:  3h 51m | Avg:  9m 38s | Max: 23m 56s | Hits:  99%/20153 
    🟨 gpu
      🟨 v100               Pass:  98%/131 | Total: 17h 46m | Avg:  8m 08s | Max: 29m 02s | Hits:  99%/107469
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🟩 90a                Pass: 100%/4   | Total: 14m 14s | Avg:  3m 33s | Max:  3m 38s | Hits:  99%/3408  
    
  • 🟩 thrust: Pass: 100%/118 | Total: 10h 38m | Avg: 5m 24s | Max: 20m 15s | Hits: 99%/139266

    🟩 cpu
      🟩 amd64              Pass: 100%/110 | Total: 10h 10m | Avg:  5m 32s | Max: 20m 15s | Hits:  99%/129822
      🟩 arm64              Pass: 100%/8   | Total: 27m 42s | Avg:  3m 27s | Max:  3m 46s | Hits:  99%/9444  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total:  1h 00m | Avg:  4m 00s | Max: 14m 46s | Hits:  99%/17705 
      🟩 11.8               Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 12.4               Pass: 100%/100 | Total:  9h 26m | Avg:  5m 40s | Max: 20m 15s | Hits:  99%/118018
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 43s | Avg:  3m 51s | Max:  3m 58s | Hits: 100%/2360  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 00m | Avg:  4m 00s | Max: 14m 46s | Hits:  99%/17705 
      🟩 nvcc11.8           Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 nvcc12.4           Pass: 100%/98  | Total:  9h 19m | Avg:  5m 42s | Max: 20m 15s | Hits:  99%/115658
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 43s | Avg:  3m 51s | Max:  3m 58s | Hits: 100%/2360  
      🟩 nvcc               Pass: 100%/116 | Total: 10h 30m | Avg:  5m 26s | Max: 20m 15s | Hits:  99%/136906
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total: 22m 57s | Avg:  3m 49s | Max:  4m 55s | Hits: 100%/7080  
      🟩 Clang10            Pass: 100%/3   | Total: 13m 13s | Avg:  4m 24s | Max:  4m 43s | Hits: 100%/3540  
      🟩 Clang11            Pass: 100%/4   | Total: 15m 16s | Avg:  3m 49s | Max:  4m 00s | Hits: 100%/4720  
      🟩 Clang12            Pass: 100%/4   | Total: 15m 02s | Avg:  3m 45s | Max:  4m 02s | Hits: 100%/4720  
      🟩 Clang13            Pass: 100%/4   | Total: 14m 37s | Avg:  3m 39s | Max:  3m 49s | Hits: 100%/4720  
      🟩 Clang14            Pass: 100%/4   | Total: 14m 57s | Avg:  3m 44s | Max:  3m 50s | Hits: 100%/4720  
      🟩 Clang15            Pass: 100%/4   | Total: 14m 45s | Avg:  3m 41s | Max:  3m 47s | Hits: 100%/4720  
      🟩 Clang16            Pass: 100%/4   | Total: 15m 00s | Avg:  3m 45s | Max:  3m 54s | Hits: 100%/4720  
      🟩 Clang17            Pass: 100%/18  | Total:  1h 58m | Avg:  6m 33s | Max: 15m 58s | Hits: 100%/21240 
      🟩 GCC6               Pass: 100%/2   | Total:  6m 16s | Avg:  3m 08s | Max:  3m 16s | Hits:  99%/2360  
      🟩 GCC7               Pass: 100%/6   | Total: 19m 45s | Avg:  3m 17s | Max:  3m 46s | Hits:  99%/7086  
      🟩 GCC8               Pass: 100%/6   | Total: 20m 26s | Avg:  3m 24s | Max:  3m 40s | Hits:  99%/7086  
      🟩 GCC9               Pass: 100%/6   | Total: 21m 33s | Avg:  3m 35s | Max:  3m 58s | Hits:  99%/7086  
      🟩 GCC10              Pass: 100%/4   | Total: 14m 34s | Avg:  3m 38s | Max:  3m 49s | Hits:  99%/4724  
      🟩 GCC11              Pass: 100%/7   | Total: 26m 14s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/8267  
      🟩 GCC12              Pass: 100%/4   | Total: 15m 35s | Avg:  3m 53s | Max:  4m 07s | Hits:  99%/4724  
      🟩 GCC13              Pass: 100%/20  | Total:  1h 57m | Avg:  5m 51s | Max: 12m 58s | Hits:  99%/23620 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 27s | Avg:  4m 29s | Max:  4m 40s | Hits: 100%/3549  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 46s | Avg: 14m 46s | Max: 14m 46s | Hits:  98%/1176  
      🟩 MSVC14.29          Pass: 100%/2   | Total: 25m 24s | Avg: 12m 42s | Max: 13m 17s | Hits:  98%/2352  
      🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 39m | Avg: 16m 31s | Max: 20m 15s | Hits:  98%/7056  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/51  | Total:  4h 03m | Avg:  4m 46s | Max: 15m 58s | Hits: 100%/60180 
      🟩 GCC                Pass: 100%/55  | Total:  4h 01m | Avg:  4m 23s | Max: 12m 58s | Hits:  99%/64953 
      🟩 Intel              Pass: 100%/3   | Total: 13m 27s | Avg:  4m 29s | Max:  4m 40s | Hits: 100%/3549  
      🟩 MSVC               Pass: 100%/9   | Total:  2h 19m | Avg: 15m 28s | Max: 20m 15s | Hits:  98%/10584 
    🟩 gpu
      🟩 v100               Pass: 100%/118 | Total: 10h 38m | Avg:  5m 24s | Max: 20m 15s | Hits:  99%/139266
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  7h 03m | Avg:  4m 16s | Max: 14m 46s | Hits:  99%/116850
      🟩 TestCPU            Pass: 100%/11  | Total:  1h 49m | Avg:  9m 54s | Max: 20m 15s | Hits:  99%/12972 
      🟩 TestGPU            Pass: 100%/8   | Total:  1h 45m | Avg: 13m 14s | Max: 15m 58s | Hits:  99%/9444  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 90a                Pass: 100%/4   | Total: 13m 29s | Avg:  3m 22s | Max:  3m 29s | Hits:  99%/4724  
    🟩 std
      🟩 11                 Pass: 100%/30  | Total:  2h 10m | Avg:  4m 20s | Max: 14m 12s | Hits:  99%/35418 
      🟩 14                 Pass: 100%/34  | Total:  3h 11m | Avg:  5m 38s | Max: 19m 01s | Hits:  99%/40122 
      🟩 17                 Pass: 100%/33  | Total:  3h 04m | Avg:  5m 35s | Max: 20m 07s | Hits:  99%/38946 
      🟩 20                 Pass: 100%/21  | Total:  2h 11m | Avg:  6m 16s | Max: 20m 15s | Hits:  99%/24780 
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental

🏃‍ Runner counts (total jobs: 249)

# Runner
178 linux-amd64-cpu16
40 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

Copy link
Contributor

🟨 CI finished in 3h 02m: Pass: 99%/249 | Total: 1d 04h | Avg: 6m 53s | Max: 29m 02s | Hits: 99%/247587
  • 🟨 cub: Pass: 99%/131 | Total: 17h 58m | Avg: 8m 13s | Max: 29m 02s | Hits: 99%/108321

    🔍 cpu: amd64 🔍
      🔍 amd64              Pass:  99%/123 | Total: 17h 24m | Avg:  8m 29s | Max: 29m 02s | Hits:  99%/101505
      🟩 arm64              Pass: 100%/8   | Total: 34m 08s | Avg:  4m 16s | Max:  4m 46s | Hits:  99%/6816  
    🔍 ctk: 12.4 🔍
      🟩 11.1               Pass: 100%/15  | Total:  1h 04m | Avg:  4m 17s | Max: 15m 09s | Hits:  99%/11568 
      🟩 11.8               Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🔍 12.4               Pass:  99%/113 | Total: 16h 40m | Avg:  8m 50s | Max: 29m 02s | Hits:  99%/94197 
    🔍 cudacxx: nvcc12.4 🔍
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s | Hits: 100%/1408  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 04m | Avg:  4m 17s | Max: 15m 09s | Hits:  99%/11568 
      🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🔍 nvcc12.4           Pass:  99%/111 | Total: 16h 32m | Avg:  8m 56s | Max: 29m 02s | Hits:  99%/92789 
    🔍 cudacxx_family: nvcc 🔍
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s | Hits: 100%/1408  
      🔍 nvcc               Pass:  99%/129 | Total: 17h 51m | Avg:  8m 18s | Max: 29m 02s | Hits:  99%/106913
    🔍 cxx: GCC13 🔍
      🟩 Clang9             Pass: 100%/6   | Total: 26m 45s | Avg:  4m 27s | Max:  5m 14s | Hits: 100%/4890  
      🟩 Clang10            Pass: 100%/3   | Total: 15m 16s | Avg:  5m 05s | Max:  5m 08s | Hits: 100%/2562  
      🟩 Clang11            Pass: 100%/4   | Total: 17m 34s | Avg:  4m 23s | Max:  4m 33s | Hits: 100%/3416  
      🟩 Clang12            Pass: 100%/4   | Total: 17m 15s | Avg:  4m 18s | Max:  4m 24s | Hits: 100%/3416  
      🟩 Clang13            Pass: 100%/4   | Total: 17m 17s | Avg:  4m 19s | Max:  4m 23s | Hits: 100%/3416  
      🟩 Clang14            Pass: 100%/4   | Total: 17m 13s | Avg:  4m 18s | Max:  4m 29s | Hits: 100%/3416  
      🟩 Clang15            Pass: 100%/4   | Total: 17m 38s | Avg:  4m 24s | Max:  4m 34s | Hits: 100%/3408  
      🟩 Clang16            Pass: 100%/4   | Total: 17m 35s | Avg:  4m 23s | Max:  4m 26s | Hits: 100%/3408  
      🟩 Clang17            Pass: 100%/26  | Total:  5h 53m | Avg: 13m 35s | Max: 26m 56s | Hits: 100%/21856 
      🟩 GCC6               Pass: 100%/2   | Total:  6m 58s | Avg:  3m 29s | Max:  3m 34s | Hits:  99%/1552  
      🟩 GCC7               Pass: 100%/6   | Total: 22m 49s | Avg:  3m 48s | Max:  4m 26s | Hits:  99%/4893  
      🟩 GCC8               Pass: 100%/6   | Total: 23m 22s | Avg:  3m 53s | Max:  4m 27s | Hits:  99%/4893  
      🟩 GCC9               Pass: 100%/6   | Total: 23m 15s | Avg:  3m 52s | Max:  4m 33s | Hits:  99%/4893  
      🟩 GCC10              Pass: 100%/4   | Total: 17m 02s | Avg:  4m 15s | Max:  4m 18s | Hits:  99%/3416  
      🟩 GCC11              Pass: 100%/7   | Total: 31m 11s | Avg:  4m 27s | Max:  4m 40s | Hits:  99%/5964  
      🟩 GCC12              Pass: 100%/4   | Total: 17m 57s | Avg:  4m 29s | Max:  4m 41s | Hits:  99%/3408  
      🔍 GCC13              Pass:  96%/28  | Total:  5h 42m | Avg: 12m 14s | Max: 29m 02s | Hits:  99%/23004 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 14m 59s | Avg:  4m 59s | Max:  5m 12s | Hits: 100%/2340  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 15m 09s | Avg: 15m 09s | Max: 15m 09s | Hits:  98%/695   
      🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 48s | Avg: 12m 24s | Max: 12m 43s | Hits:  98%/1390  
      🟩 MSVC14.39          Pass: 100%/3   | Total: 38m 13s | Avg: 12m 44s | Max: 13m 27s | Hits:  98%/2085  
    🔍 cxx_family: GCC 🔍
      🟩 Clang              Pass: 100%/59  | Total:  8h 19m | Avg:  8m 28s | Max: 26m 56s | Hits: 100%/49788 
      🔍 GCC                Pass:  98%/63  | Total:  8h 05m | Avg:  7m 42s | Max: 29m 02s | Hits:  99%/52023 
      🟩 Intel              Pass: 100%/3   | Total: 14m 59s | Avg:  4m 59s | Max:  5m 12s | Hits: 100%/2340  
      🟩 MSVC               Pass: 100%/6   | Total:  1h 18m | Avg: 13m 01s | Max: 15m 09s | Hits:  98%/4170  
    🔍 jobs: HostLaunch 🔍
      🟩 Build              Pass: 100%/99  | Total:  7h 53m | Avg:  4m 47s | Max: 15m 09s | Hits:  99%/81909 
      🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 22m | Avg: 17m 49s | Max: 20m 50s | Hits:  99%/6816  
      🟩 GraphCapture       Pass: 100%/8   | Total:  2h 09m | Avg: 16m 12s | Max: 18m 52s | Hits:  99%/6816  
      🔍 HostLaunch         Pass:  87%/8   | Total:  2h 12m | Avg: 16m 36s | Max: 20m 31s | Hits:  99%/5964  
      🟩 TestGPU            Pass: 100%/8   | Total:  3h 19m | Avg: 24m 56s | Max: 29m 02s | Hits:  99%/6816  
    🔍 std: 14 🔍
      🟩 11                 Pass: 100%/34  | Total:  4h 32m | Avg:  8m 00s | Max: 29m 02s | Hits:  99%/28539 
      🔍 14                 Pass:  97%/37  | Total:  4h 47m | Avg:  7m 46s | Max: 26m 56s | Hits:  99%/29772 
      🟩 17                 Pass: 100%/36  | Total:  4h 47m | Avg:  7m 59s | Max: 26m 04s | Hits:  99%/29857 
      🟩 20                 Pass: 100%/24  | Total:  3h 51m | Avg:  9m 38s | Max: 23m 56s | Hits:  99%/20153 
    🟨 gpu
      🟨 v100               Pass:  99%/131 | Total: 17h 58m | Avg:  8m 13s | Max: 29m 02s | Hits:  99%/108321
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🟩 90a                Pass: 100%/4   | Total: 14m 14s | Avg:  3m 33s | Max:  3m 38s | Hits:  99%/3408  
    
  • 🟩 thrust: Pass: 100%/118 | Total: 10h 38m | Avg: 5m 24s | Max: 20m 15s | Hits: 99%/139266

    🟩 cpu
      🟩 amd64              Pass: 100%/110 | Total: 10h 10m | Avg:  5m 32s | Max: 20m 15s | Hits:  99%/129822
      🟩 arm64              Pass: 100%/8   | Total: 27m 42s | Avg:  3m 27s | Max:  3m 46s | Hits:  99%/9444  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total:  1h 00m | Avg:  4m 00s | Max: 14m 46s | Hits:  99%/17705 
      🟩 11.8               Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 12.4               Pass: 100%/100 | Total:  9h 26m | Avg:  5m 40s | Max: 20m 15s | Hits:  99%/118018
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 43s | Avg:  3m 51s | Max:  3m 58s | Hits: 100%/2360  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 00m | Avg:  4m 00s | Max: 14m 46s | Hits:  99%/17705 
      🟩 nvcc11.8           Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 nvcc12.4           Pass: 100%/98  | Total:  9h 19m | Avg:  5m 42s | Max: 20m 15s | Hits:  99%/115658
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 43s | Avg:  3m 51s | Max:  3m 58s | Hits: 100%/2360  
      🟩 nvcc               Pass: 100%/116 | Total: 10h 30m | Avg:  5m 26s | Max: 20m 15s | Hits:  99%/136906
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total: 22m 57s | Avg:  3m 49s | Max:  4m 55s | Hits: 100%/7080  
      🟩 Clang10            Pass: 100%/3   | Total: 13m 13s | Avg:  4m 24s | Max:  4m 43s | Hits: 100%/3540  
      🟩 Clang11            Pass: 100%/4   | Total: 15m 16s | Avg:  3m 49s | Max:  4m 00s | Hits: 100%/4720  
      🟩 Clang12            Pass: 100%/4   | Total: 15m 02s | Avg:  3m 45s | Max:  4m 02s | Hits: 100%/4720  
      🟩 Clang13            Pass: 100%/4   | Total: 14m 37s | Avg:  3m 39s | Max:  3m 49s | Hits: 100%/4720  
      🟩 Clang14            Pass: 100%/4   | Total: 14m 57s | Avg:  3m 44s | Max:  3m 50s | Hits: 100%/4720  
      🟩 Clang15            Pass: 100%/4   | Total: 14m 45s | Avg:  3m 41s | Max:  3m 47s | Hits: 100%/4720  
      🟩 Clang16            Pass: 100%/4   | Total: 15m 00s | Avg:  3m 45s | Max:  3m 54s | Hits: 100%/4720  
      🟩 Clang17            Pass: 100%/18  | Total:  1h 58m | Avg:  6m 33s | Max: 15m 58s | Hits: 100%/21240 
      🟩 GCC6               Pass: 100%/2   | Total:  6m 16s | Avg:  3m 08s | Max:  3m 16s | Hits:  99%/2360  
      🟩 GCC7               Pass: 100%/6   | Total: 19m 45s | Avg:  3m 17s | Max:  3m 46s | Hits:  99%/7086  
      🟩 GCC8               Pass: 100%/6   | Total: 20m 26s | Avg:  3m 24s | Max:  3m 40s | Hits:  99%/7086  
      🟩 GCC9               Pass: 100%/6   | Total: 21m 33s | Avg:  3m 35s | Max:  3m 58s | Hits:  99%/7086  
      🟩 GCC10              Pass: 100%/4   | Total: 14m 34s | Avg:  3m 38s | Max:  3m 49s | Hits:  99%/4724  
      🟩 GCC11              Pass: 100%/7   | Total: 26m 14s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/8267  
      🟩 GCC12              Pass: 100%/4   | Total: 15m 35s | Avg:  3m 53s | Max:  4m 07s | Hits:  99%/4724  
      🟩 GCC13              Pass: 100%/20  | Total:  1h 57m | Avg:  5m 51s | Max: 12m 58s | Hits:  99%/23620 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 27s | Avg:  4m 29s | Max:  4m 40s | Hits: 100%/3549  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 46s | Avg: 14m 46s | Max: 14m 46s | Hits:  98%/1176  
      🟩 MSVC14.29          Pass: 100%/2   | Total: 25m 24s | Avg: 12m 42s | Max: 13m 17s | Hits:  98%/2352  
      🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 39m | Avg: 16m 31s | Max: 20m 15s | Hits:  98%/7056  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/51  | Total:  4h 03m | Avg:  4m 46s | Max: 15m 58s | Hits: 100%/60180 
      🟩 GCC                Pass: 100%/55  | Total:  4h 01m | Avg:  4m 23s | Max: 12m 58s | Hits:  99%/64953 
      🟩 Intel              Pass: 100%/3   | Total: 13m 27s | Avg:  4m 29s | Max:  4m 40s | Hits: 100%/3549  
      🟩 MSVC               Pass: 100%/9   | Total:  2h 19m | Avg: 15m 28s | Max: 20m 15s | Hits:  98%/10584 
    🟩 gpu
      🟩 v100               Pass: 100%/118 | Total: 10h 38m | Avg:  5m 24s | Max: 20m 15s | Hits:  99%/139266
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  7h 03m | Avg:  4m 16s | Max: 14m 46s | Hits:  99%/116850
      🟩 TestCPU            Pass: 100%/11  | Total:  1h 49m | Avg:  9m 54s | Max: 20m 15s | Hits:  99%/12972 
      🟩 TestGPU            Pass: 100%/8   | Total:  1h 45m | Avg: 13m 14s | Max: 15m 58s | Hits:  99%/9444  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 90a                Pass: 100%/4   | Total: 13m 29s | Avg:  3m 22s | Max:  3m 29s | Hits:  99%/4724  
    🟩 std
      🟩 11                 Pass: 100%/30  | Total:  2h 10m | Avg:  4m 20s | Max: 14m 12s | Hits:  99%/35418 
      🟩 14                 Pass: 100%/34  | Total:  3h 11m | Avg:  5m 38s | Max: 19m 01s | Hits:  99%/40122 
      🟩 17                 Pass: 100%/33  | Total:  3h 04m | Avg:  5m 35s | Max: 20m 07s | Hits:  99%/38946 
      🟩 20                 Pass: 100%/21  | Total:  2h 11m | Avg:  6m 16s | Max: 20m 15s | Hits:  99%/24780 
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental

🏃‍ Runner counts (total jobs: 249)

# Runner
178 linux-amd64-cpu16
40 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

Copy link
Contributor

🟩 CI finished in 12h 29m: Pass: 100%/249 | Total: 1d 04h | Avg: 6m 56s | Max: 29m 02s | Hits: 99%/248439
  • 🟩 cub: Pass: 100%/131 | Total: 18h 08m | Avg: 8m 18s | Max: 29m 02s | Hits: 99%/109173

    🟩 cpu
      🟩 amd64              Pass: 100%/123 | Total: 17h 34m | Avg:  8m 34s | Max: 29m 02s | Hits:  99%/102357
      🟩 arm64              Pass: 100%/8   | Total: 34m 08s | Avg:  4m 16s | Max:  4m 46s | Hits:  99%/6816  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total:  1h 04m | Avg:  4m 17s | Max: 15m 09s | Hits:  99%/11568 
      🟩 11.8               Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🟩 12.4               Pass: 100%/113 | Total: 16h 50m | Avg:  8m 56s | Max: 29m 02s | Hits:  99%/95049 
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s | Hits: 100%/1408  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 04m | Avg:  4m 17s | Max: 15m 09s | Hits:  99%/11568 
      🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🟩 nvcc12.4           Pass: 100%/111 | Total: 16h 42m | Avg:  9m 02s | Max: 29m 02s | Hits:  99%/93641 
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 09s | Avg:  3m 34s | Max:  3m 36s | Hits: 100%/1408  
      🟩 nvcc               Pass: 100%/129 | Total: 18h 01m | Avg:  8m 22s | Max: 29m 02s | Hits:  99%/107765
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total: 26m 45s | Avg:  4m 27s | Max:  5m 14s | Hits: 100%/4890  
      🟩 Clang10            Pass: 100%/3   | Total: 15m 16s | Avg:  5m 05s | Max:  5m 08s | Hits: 100%/2562  
      🟩 Clang11            Pass: 100%/4   | Total: 17m 34s | Avg:  4m 23s | Max:  4m 33s | Hits: 100%/3416  
      🟩 Clang12            Pass: 100%/4   | Total: 17m 15s | Avg:  4m 18s | Max:  4m 24s | Hits: 100%/3416  
      🟩 Clang13            Pass: 100%/4   | Total: 17m 17s | Avg:  4m 19s | Max:  4m 23s | Hits: 100%/3416  
      🟩 Clang14            Pass: 100%/4   | Total: 17m 13s | Avg:  4m 18s | Max:  4m 29s | Hits: 100%/3416  
      🟩 Clang15            Pass: 100%/4   | Total: 17m 38s | Avg:  4m 24s | Max:  4m 34s | Hits: 100%/3408  
      🟩 Clang16            Pass: 100%/4   | Total: 17m 35s | Avg:  4m 23s | Max:  4m 26s | Hits: 100%/3408  
      🟩 Clang17            Pass: 100%/26  | Total:  5h 53m | Avg: 13m 35s | Max: 26m 56s | Hits: 100%/21856 
      🟩 GCC6               Pass: 100%/2   | Total:  6m 58s | Avg:  3m 29s | Max:  3m 34s | Hits:  99%/1552  
      🟩 GCC7               Pass: 100%/6   | Total: 22m 49s | Avg:  3m 48s | Max:  4m 26s | Hits:  99%/4893  
      🟩 GCC8               Pass: 100%/6   | Total: 23m 22s | Avg:  3m 53s | Max:  4m 27s | Hits:  99%/4893  
      🟩 GCC9               Pass: 100%/6   | Total: 23m 15s | Avg:  3m 52s | Max:  4m 33s | Hits:  99%/4893  
      🟩 GCC10              Pass: 100%/4   | Total: 17m 02s | Avg:  4m 15s | Max:  4m 18s | Hits:  99%/3416  
      🟩 GCC11              Pass: 100%/7   | Total: 31m 11s | Avg:  4m 27s | Max:  4m 40s | Hits:  99%/5964  
      🟩 GCC12              Pass: 100%/4   | Total: 17m 57s | Avg:  4m 29s | Max:  4m 41s | Hits:  99%/3408  
      🟩 GCC13              Pass: 100%/28  | Total:  5h 52m | Avg: 12m 36s | Max: 29m 02s | Hits:  99%/23856 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 14m 59s | Avg:  4m 59s | Max:  5m 12s | Hits: 100%/2340  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 15m 09s | Avg: 15m 09s | Max: 15m 09s | Hits:  98%/695   
      🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 48s | Avg: 12m 24s | Max: 12m 43s | Hits:  98%/1390  
      🟩 MSVC14.39          Pass: 100%/3   | Total: 38m 13s | Avg: 12m 44s | Max: 13m 27s | Hits:  98%/2085  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/59  | Total:  8h 19m | Avg:  8m 28s | Max: 26m 56s | Hits: 100%/49788 
      🟩 GCC                Pass: 100%/63  | Total:  8h 15m | Avg:  7m 51s | Max: 29m 02s | Hits:  99%/52875 
      🟩 Intel              Pass: 100%/3   | Total: 14m 59s | Avg:  4m 59s | Max:  5m 12s | Hits: 100%/2340  
      🟩 MSVC               Pass: 100%/6   | Total:  1h 18m | Avg: 13m 01s | Max: 15m 09s | Hits:  98%/4170  
    🟩 gpu
      🟩 v100               Pass: 100%/131 | Total: 18h 08m | Avg:  8m 18s | Max: 29m 02s | Hits:  99%/109173
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  7h 53m | Avg:  4m 47s | Max: 15m 09s | Hits:  99%/81909 
      🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 22m | Avg: 17m 49s | Max: 20m 50s | Hits:  99%/6816  
      🟩 GraphCapture       Pass: 100%/8   | Total:  2h 09m | Avg: 16m 12s | Max: 18m 52s | Hits:  99%/6816  
      🟩 HostLaunch         Pass: 100%/8   | Total:  2h 22m | Avg: 17m 51s | Max: 20m 31s | Hits:  99%/6816  
      🟩 TestGPU            Pass: 100%/8   | Total:  3h 19m | Avg: 24m 56s | Max: 29m 02s | Hits:  99%/6816  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 46s | Avg:  4m 35s | Max:  4m 40s | Hits:  99%/2556  
      🟩 90a                Pass: 100%/4   | Total: 14m 14s | Avg:  3m 33s | Max:  3m 38s | Hits:  99%/3408  
    🟩 std
      🟩 11                 Pass: 100%/34  | Total:  4h 32m | Avg:  8m 00s | Max: 29m 02s | Hits:  99%/28539 
      🟩 14                 Pass: 100%/37  | Total:  4h 57m | Avg:  8m 02s | Max: 26m 56s | Hits:  99%/30624 
      🟩 17                 Pass: 100%/36  | Total:  4h 47m | Avg:  7m 59s | Max: 26m 04s | Hits:  99%/29857 
      🟩 20                 Pass: 100%/24  | Total:  3h 51m | Avg:  9m 38s | Max: 23m 56s | Hits:  99%/20153 
    
  • 🟩 thrust: Pass: 100%/118 | Total: 10h 38m | Avg: 5m 24s | Max: 20m 15s | Hits: 99%/139266

    🟩 cpu
      🟩 amd64              Pass: 100%/110 | Total: 10h 10m | Avg:  5m 32s | Max: 20m 15s | Hits:  99%/129822
      🟩 arm64              Pass: 100%/8   | Total: 27m 42s | Avg:  3m 27s | Max:  3m 46s | Hits:  99%/9444  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total:  1h 00m | Avg:  4m 00s | Max: 14m 46s | Hits:  99%/17705 
      🟩 11.8               Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 12.4               Pass: 100%/100 | Total:  9h 26m | Avg:  5m 40s | Max: 20m 15s | Hits:  99%/118018
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 43s | Avg:  3m 51s | Max:  3m 58s | Hits: 100%/2360  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 00m | Avg:  4m 00s | Max: 14m 46s | Hits:  99%/17705 
      🟩 nvcc11.8           Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 nvcc12.4           Pass: 100%/98  | Total:  9h 19m | Avg:  5m 42s | Max: 20m 15s | Hits:  99%/115658
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 43s | Avg:  3m 51s | Max:  3m 58s | Hits: 100%/2360  
      🟩 nvcc               Pass: 100%/116 | Total: 10h 30m | Avg:  5m 26s | Max: 20m 15s | Hits:  99%/136906
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total: 22m 57s | Avg:  3m 49s | Max:  4m 55s | Hits: 100%/7080  
      🟩 Clang10            Pass: 100%/3   | Total: 13m 13s | Avg:  4m 24s | Max:  4m 43s | Hits: 100%/3540  
      🟩 Clang11            Pass: 100%/4   | Total: 15m 16s | Avg:  3m 49s | Max:  4m 00s | Hits: 100%/4720  
      🟩 Clang12            Pass: 100%/4   | Total: 15m 02s | Avg:  3m 45s | Max:  4m 02s | Hits: 100%/4720  
      🟩 Clang13            Pass: 100%/4   | Total: 14m 37s | Avg:  3m 39s | Max:  3m 49s | Hits: 100%/4720  
      🟩 Clang14            Pass: 100%/4   | Total: 14m 57s | Avg:  3m 44s | Max:  3m 50s | Hits: 100%/4720  
      🟩 Clang15            Pass: 100%/4   | Total: 14m 45s | Avg:  3m 41s | Max:  3m 47s | Hits: 100%/4720  
      🟩 Clang16            Pass: 100%/4   | Total: 15m 00s | Avg:  3m 45s | Max:  3m 54s | Hits: 100%/4720  
      🟩 Clang17            Pass: 100%/18  | Total:  1h 58m | Avg:  6m 33s | Max: 15m 58s | Hits: 100%/21240 
      🟩 GCC6               Pass: 100%/2   | Total:  6m 16s | Avg:  3m 08s | Max:  3m 16s | Hits:  99%/2360  
      🟩 GCC7               Pass: 100%/6   | Total: 19m 45s | Avg:  3m 17s | Max:  3m 46s | Hits:  99%/7086  
      🟩 GCC8               Pass: 100%/6   | Total: 20m 26s | Avg:  3m 24s | Max:  3m 40s | Hits:  99%/7086  
      🟩 GCC9               Pass: 100%/6   | Total: 21m 33s | Avg:  3m 35s | Max:  3m 58s | Hits:  99%/7086  
      🟩 GCC10              Pass: 100%/4   | Total: 14m 34s | Avg:  3m 38s | Max:  3m 49s | Hits:  99%/4724  
      🟩 GCC11              Pass: 100%/7   | Total: 26m 14s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/8267  
      🟩 GCC12              Pass: 100%/4   | Total: 15m 35s | Avg:  3m 53s | Max:  4m 07s | Hits:  99%/4724  
      🟩 GCC13              Pass: 100%/20  | Total:  1h 57m | Avg:  5m 51s | Max: 12m 58s | Hits:  99%/23620 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 27s | Avg:  4m 29s | Max:  4m 40s | Hits: 100%/3549  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 46s | Avg: 14m 46s | Max: 14m 46s | Hits:  98%/1176  
      🟩 MSVC14.29          Pass: 100%/2   | Total: 25m 24s | Avg: 12m 42s | Max: 13m 17s | Hits:  98%/2352  
      🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 39m | Avg: 16m 31s | Max: 20m 15s | Hits:  98%/7056  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/51  | Total:  4h 03m | Avg:  4m 46s | Max: 15m 58s | Hits: 100%/60180 
      🟩 GCC                Pass: 100%/55  | Total:  4h 01m | Avg:  4m 23s | Max: 12m 58s | Hits:  99%/64953 
      🟩 Intel              Pass: 100%/3   | Total: 13m 27s | Avg:  4m 29s | Max:  4m 40s | Hits: 100%/3549  
      🟩 MSVC               Pass: 100%/9   | Total:  2h 19m | Avg: 15m 28s | Max: 20m 15s | Hits:  98%/10584 
    🟩 gpu
      🟩 v100               Pass: 100%/118 | Total: 10h 38m | Avg:  5m 24s | Max: 20m 15s | Hits:  99%/139266
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  7h 03m | Avg:  4m 16s | Max: 14m 46s | Hits:  99%/116850
      🟩 TestCPU            Pass: 100%/11  | Total:  1h 49m | Avg:  9m 54s | Max: 20m 15s | Hits:  99%/12972 
      🟩 TestGPU            Pass: 100%/8   | Total:  1h 45m | Avg: 13m 14s | Max: 15m 58s | Hits:  99%/9444  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total: 11m 13s | Avg:  3m 44s | Max:  3m 55s | Hits:  99%/3543  
      🟩 90a                Pass: 100%/4   | Total: 13m 29s | Avg:  3m 22s | Max:  3m 29s | Hits:  99%/4724  
    🟩 std
      🟩 11                 Pass: 100%/30  | Total:  2h 10m | Avg:  4m 20s | Max: 14m 12s | Hits:  99%/35418 
      🟩 14                 Pass: 100%/34  | Total:  3h 11m | Avg:  5m 38s | Max: 19m 01s | Hits:  99%/40122 
      🟩 17                 Pass: 100%/33  | Total:  3h 04m | Avg:  5m 35s | Max: 20m 07s | Hits:  99%/38946 
      🟩 20                 Pass: 100%/21  | Total:  2h 11m | Avg:  6m 16s | Max: 20m 15s | Hits:  99%/24780 
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental

🏃‍ Runner counts (total jobs: 249)

# Runner
178 linux-amd64-cpu16
40 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

@elstehle
Copy link
Collaborator Author

Closing in favor of #1878

@elstehle elstehle closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cub For all items related to CUB doc Documentation-related items.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants