-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assert implementation for device side testing #1918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCCL is tested in release build and by default assert is compiled out In hierarchy testing device side uses assert for convinient printing and termination, we do #indef NDEBUG to make the asserts stay. Recently I wanted to remove on extremally long running test from debug builds, but because of the #undef NDEBUG it was difficult to detect a debug build. I decided to just switch to a custom assert implementation and remove the #undef. This has another benefit that we could do warp aggregate error printing for easier readible logs etc in the future.
🟩 CI finished in 1h 45m: Pass: 100%/55 | Total: 2h 42m | Avg: 2m 57s | Max: 9m 52s | Hits: 88%/1308
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
🏃 Runner counts (total jobs: 55)
# | Runner |
---|---|
41 | linux-amd64-cpu16 |
8 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
bernhardmgruber
approved these changes
Jun 26, 2024
Co-authored-by: Bernhard Manfred Gruber <[email protected]>
🟩 CI finished in 36m 09s: Pass: 100%/55 | Total: 2h 41m | Avg: 2m 56s | Max: 10m 13s | Hits: 88%/1308
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
🏃 Runner counts (total jobs: 55)
# | Runner |
---|---|
41 | linux-amd64-cpu16 |
8 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCCL is tested in release build and by default assert is compiled out. In CUDAX hierarchy testing device side uses assert for convenient printing and termination, we do #indef NDEBUG to make the asserts stay.
Recently I wanted to remove on extremely long running test from debug builds, but because of the #undef NDEBUG it was difficult to detect a debug build.
I decided to just switch to a custom assert implementation and remove the #undef. This has another benefit that we could do warp aggregate error printing for easier readible logs etc in the future.
This change also renames HOST_DEV_REQUIRE to CUDAX_REQUIRE.