[BUG] Rework how we handle feature test macros #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would define
__cpp_lib_meow
which interferes with the host standard library.Worst case we might actually break user code, because we define some macros earlier than the host library would.
To alleviate this and also let a user check what we actually implement we rename our feature test macros to
__cccl_lib_meow
We still keep the naming convention of the standard and try to define the standard macros when applicable.
In addition to renaming we also fix some macros that should not be defined and fix some values of others
Fixes #189