Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instances of 'scan' copy-pasted into reduction documentation #221

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

milesvant
Copy link
Contributor

@milesvant milesvant commented Jul 14, 2023

Description

The reduction code has many comments erroneously labeling reductions as "scans", presumably from copy-pasting. This commit fixes all the ones I could find.

The one I couldn't fix is that the image for the documentation section here: https://nvlabs.github.io/cub/namespacecub.html#add0251c713859b8974806079e498d10aa993903176f938273fa1ff5d4daa808e5 displays a warp scan instead of a warp reduce.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rapids-bot
Copy link

rapids-bot bot commented Jul 14, 2023

Pull requests from external contributors require approval from a NVIDIA organization member with write permissions or greater before CI can begin.

Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milesvant thank you for the contribution!

@gevtushenko
Copy link
Collaborator

/ok to test

@gevtushenko gevtushenko merged commit 145f880 into NVIDIA:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants