Rework mdspan concept emulation #2213

miscco · 2024-08-09T11:47:12Z

It is proving difficult to handle for msvc and also the one we are using in libcu++ it much cleaner

Gets #2160 compiling on MSVC

It is proving difficult to handle for msvc and also the one we are using in libcu++ it much cleaner Gets NVIDIA#2160 compiling on MSVC

miscco · 2024-08-09T11:51:25Z

libcudacxx/include/cuda/std/__mdspan/layout_stride.h

+    // nvcc cannot deduce this constructor when using _LIBCUDACXX_REQUIRES
+    template <
      class _IntegralTypes,
-      /* requires */ (
-        // MSVC 19.32 does not like using index_type here, requires the typename _Extents::index_type
-        // error C2641: cannot deduce template arguments for '_CUDA_VSTD::layout_stride::mapping'
-        _CCCL_TRAIT(_CUDA_VSTD::is_convertible, const remove_const_t<_IntegralTypes>&, typename _Extents::index_type)
-        && _CCCL_TRAIT(
-          _CUDA_VSTD::is_nothrow_constructible, typename _Extents::index_type, const remove_const_t<_IntegralTypes>&)))
-    __MDSPAN_INLINE_FUNCTION
-    constexpr mapping(extents_type const& __e,
-                      _CUDA_VSTD::span<_IntegralTypes, extents_type::rank()> const& __s) noexcept
+      enable_if_t<_CCCL_TRAIT(is_convertible, const remove_const_t<_IntegralTypes>&, index_type), int>           = 0,
+      enable_if_t<_CCCL_TRAIT(is_nothrow_constructible, index_type, const remove_const_t<_IntegralTypes>&), int> = 0>


This might have been the breaking thing, because nvcc has issues deducing the template arguments here otherwise

ericniebler

wow. this looks like it was a lot of work. THANK YOU.

github-actions · 2024-08-09T15:14:20Z

🟩 CI finished in 3h 24m: Pass: 100%/417 | Total: 2d 02h | Avg: 7m 19s | Max: 1h 02m | Hits: 98%/31306

🟩 cub: Pass: 100%/131 | Total: 21h 53m | Avg: 10m 01s | Max: 1h 02m | Hits: 99%/4254

🟩 cpu
  🟩 amd64              Pass: 100%/123 | Total: 21h 16m | Avg: 10m 22s | Max:  1h 02m | Hits:  99%/4254  
  🟩 arm64              Pass: 100%/8   | Total: 37m 27s | Avg:  4m 40s | Max:  5m 18s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 01m | Avg:  4m 07s | Max: 12m 15s | Hits:  99%/709   
  🟩 11.8               Pass: 100%/3   | Total: 13m 21s | Avg:  4m 27s | Max:  4m 31s
  🟩 12.5               Pass: 100%/113 | Total: 20h 38m | Avg: 10m 57s | Max:  1h 02m | Hits:  99%/3545  
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 03s | Avg:  3m 31s | Max:  3m 33s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 01m | Avg:  4m 07s | Max: 12m 15s | Hits:  99%/709   
  🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 21s | Avg:  4m 27s | Max:  4m 31s
  🟩 nvcc12.5           Pass: 100%/111 | Total: 20h 31m | Avg: 11m 05s | Max:  1h 02m | Hits:  99%/3545  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 03s | Avg:  3m 31s | Max:  3m 33s
  🟩 nvcc               Pass: 100%/129 | Total: 21h 46m | Avg: 10m 07s | Max:  1h 02m | Hits:  99%/4254  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 27m 18s | Avg:  4m 33s | Max:  5m 26s
  🟩 Clang10            Pass: 100%/3   | Total: 15m 07s | Avg:  5m 02s | Max:  5m 34s
  🟩 Clang11            Pass: 100%/4   | Total: 17m 12s | Avg:  4m 18s | Max:  4m 33s
  🟩 Clang12            Pass: 100%/4   | Total: 17m 45s | Avg:  4m 26s | Max:  4m 30s
  🟩 Clang13            Pass: 100%/4   | Total: 17m 06s | Avg:  4m 16s | Max:  4m 34s
  🟩 Clang14            Pass: 100%/4   | Total: 17m 52s | Avg:  4m 28s | Max:  4m 43s
  🟩 Clang15            Pass: 100%/4   | Total: 18m 03s | Avg:  4m 30s | Max:  4m 40s
  🟩 Clang16            Pass: 100%/4   | Total: 17m 48s | Avg:  4m 27s | Max:  4m 31s
  🟩 Clang17            Pass: 100%/26  | Total:  7h 21m | Avg: 16m 59s | Max:  1h 02m
  🟩 GCC6               Pass: 100%/2   | Total:  7m 03s | Avg:  3m 31s | Max:  3m 40s
  🟩 GCC7               Pass: 100%/6   | Total: 21m 59s | Avg:  3m 39s | Max:  4m 06s
  🟩 GCC8               Pass: 100%/6   | Total: 22m 33s | Avg:  3m 45s | Max:  4m 09s
  🟩 GCC9               Pass: 100%/6   | Total: 24m 30s | Avg:  4m 05s | Max:  4m 42s
  🟩 GCC10              Pass: 100%/4   | Total: 18m 00s | Avg:  4m 30s | Max:  4m 57s
  🟩 GCC11              Pass: 100%/7   | Total: 30m 37s | Avg:  4m 22s | Max:  4m 49s
  🟩 GCC12              Pass: 100%/4   | Total: 18m 36s | Avg:  4m 39s | Max:  4m 50s
  🟩 GCC13              Pass: 100%/28  | Total:  8h 21m | Avg: 17m 55s | Max: 50m 57s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 15m 03s | Avg:  5m 01s | Max:  5m 15s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 12m 15s | Avg: 12m 15s | Max: 12m 15s | Hits:  99%/709   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 18m 56s | Avg:  9m 28s | Max:  9m 32s | Hits:  99%/1418  
  🟩 MSVC14.39          Pass: 100%/3   | Total: 32m 28s | Avg: 10m 49s | Max: 11m 42s | Hits:  99%/2127  
🟩 cxx_family
  🟩 Clang              Pass: 100%/59  | Total:  9h 49m | Avg:  9m 59s | Max:  1h 02m
  🟩 GCC                Pass: 100%/63  | Total: 10h 45m | Avg: 10m 14s | Max: 50m 57s
  🟩 Intel              Pass: 100%/3   | Total: 15m 03s | Avg:  5m 01s | Max:  5m 15s
  🟩 MSVC               Pass: 100%/6   | Total:  1h 03m | Avg: 10m 36s | Max: 12m 15s | Hits:  99%/4254  
🟩 gpu
  🟩 v100               Pass: 100%/131 | Total: 21h 53m | Avg: 10m 01s | Max:  1h 02m | Hits:  99%/4254  
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  7h 46m | Avg:  4m 42s | Max: 12m 15s | Hits:  99%/4254  
  🟩 DeviceLaunch       Pass: 100%/8   | Total:  3h 03m | Avg: 22m 57s | Max: 33m 02s
  🟩 GraphCapture       Pass: 100%/8   | Total:  2h 59m | Avg: 22m 24s | Max: 34m 56s
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 57m | Avg: 22m 13s | Max: 30m 25s
  🟩 TestGPU            Pass: 100%/8   | Total:  5h 07m | Avg: 38m 22s | Max:  1h 02m
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 21s | Avg:  4m 27s | Max:  4m 31s
  🟩 90a                Pass: 100%/4   | Total: 14m 39s | Avg:  3m 39s | Max:  3m 48s
🟩 std
  🟩 11                 Pass: 100%/34  | Total:  4h 43m | Avg:  8m 20s | Max: 34m 47s
  🟩 14                 Pass: 100%/37  | Total:  5h 14m | Avg:  8m 30s | Max: 29m 58s | Hits:  99%/2127  
  🟩 17                 Pass: 100%/36  | Total:  6h 30m | Avg: 10m 50s | Max:  1h 02m | Hits:  99%/1418  
  🟩 20                 Pass: 100%/24  | Total:  5h 25m | Avg: 13m 33s | Max: 50m 19s | Hits:  99%/709

🟩 thrust: Pass: 100%/118 | Total: 11h 17m | Avg: 5m 44s | Max: 34m 58s | Hits: 98%/10557

🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total: 10h 45m | Avg:  5m 52s | Max: 34m 58s | Hits:  98%/10557 
  🟩 arm64              Pass: 100%/8   | Total: 32m 19s | Avg:  4m 02s | Max:  4m 31s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total: 59m 18s | Avg:  3m 57s | Max: 13m 16s | Hits:  98%/1173  
  🟩 11.8               Pass: 100%/3   | Total: 10m 34s | Avg:  3m 31s | Max:  3m 50s
  🟩 12.5               Pass: 100%/100 | Total: 10h 07m | Avg:  6m 04s | Max: 34m 58s | Hits:  98%/9384  
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 08s | Avg:  3m 34s | Max:  3m 37s
  🟩 nvcc11.1           Pass: 100%/15  | Total: 59m 18s | Avg:  3m 57s | Max: 13m 16s | Hits:  98%/1173  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 10m 34s | Avg:  3m 31s | Max:  3m 50s
  🟩 nvcc12.5           Pass: 100%/98  | Total: 10h 00m | Avg:  6m 07s | Max: 34m 58s | Hits:  98%/9384  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 08s | Avg:  3m 34s | Max:  3m 37s
  🟩 nvcc               Pass: 100%/116 | Total: 11h 10m | Avg:  5m 46s | Max: 34m 58s | Hits:  98%/10557 
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 23m 47s | Avg:  3m 57s | Max:  4m 45s
  🟩 Clang10            Pass: 100%/3   | Total: 13m 23s | Avg:  4m 27s | Max:  4m 29s
  🟩 Clang11            Pass: 100%/4   | Total: 13m 56s | Avg:  3m 29s | Max:  3m 32s
  🟩 Clang12            Pass: 100%/4   | Total: 14m 16s | Avg:  3m 34s | Max:  3m 43s
  🟩 Clang13            Pass: 100%/4   | Total: 14m 52s | Avg:  3m 43s | Max:  3m 52s
  🟩 Clang14            Pass: 100%/4   | Total: 15m 28s | Avg:  3m 52s | Max:  4m 11s
  🟩 Clang15            Pass: 100%/4   | Total: 15m 08s | Avg:  3m 47s | Max:  4m 08s
  🟩 Clang16            Pass: 100%/4   | Total: 14m 59s | Avg:  3m 44s | Max:  4m 01s
  🟩 Clang17            Pass: 100%/18  | Total:  2h 45m | Avg:  9m 11s | Max: 34m 58s
  🟩 GCC6               Pass: 100%/2   | Total:  6m 45s | Avg:  3m 22s | Max:  3m 26s
  🟩 GCC7               Pass: 100%/6   | Total: 20m 32s | Avg:  3m 25s | Max:  4m 18s
  🟩 GCC8               Pass: 100%/6   | Total: 20m 36s | Avg:  3m 26s | Max:  3m 45s
  🟩 GCC9               Pass: 100%/6   | Total: 20m 39s | Avg:  3m 26s | Max:  4m 12s
  🟩 GCC10              Pass: 100%/4   | Total: 14m 47s | Avg:  3m 41s | Max:  3m 49s
  🟩 GCC11              Pass: 100%/7   | Total: 25m 43s | Avg:  3m 40s | Max:  4m 11s
  🟩 GCC12              Pass: 100%/4   | Total: 15m 27s | Avg:  3m 51s | Max:  4m 10s
  🟩 GCC13              Pass: 100%/20  | Total:  2h 03m | Avg:  6m 10s | Max: 15m 25s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 49s | Avg:  4m 36s | Max:  4m 45s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 13m 16s | Avg: 13m 16s | Max: 13m 16s | Hits:  98%/1173  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 23m 00s | Avg: 11m 30s | Max: 12m 09s | Hits:  98%/2346  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 28m | Avg: 14m 44s | Max: 19m 26s | Hits:  98%/7038  
🟩 cxx_family
  🟩 Clang              Pass: 100%/51  | Total:  4h 51m | Avg:  5m 42s | Max: 34m 58s
  🟩 GCC                Pass: 100%/55  | Total:  4h 07m | Avg:  4m 30s | Max: 15m 25s
  🟩 Intel              Pass: 100%/3   | Total: 13m 49s | Avg:  4m 36s | Max:  4m 45s
  🟩 MSVC               Pass: 100%/9   | Total:  2h 04m | Avg: 13m 51s | Max: 19m 26s | Hits:  98%/10557 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total: 11h 17m | Avg:  5m 44s | Max: 34m 58s | Hits:  98%/10557 
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  7h 01m | Avg:  4m 15s | Max: 13m 16s | Hits:  98%/7038  
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 42m | Avg:  9m 16s | Max: 19m 26s | Hits:  98%/3519  
  🟩 TestGPU            Pass: 100%/8   | Total:  2h 34m | Avg: 19m 20s | Max: 34m 58s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 10m 34s | Avg:  3m 31s | Max:  3m 50s
  🟩 90a                Pass: 100%/4   | Total: 13m 51s | Avg:  3m 27s | Max:  3m 43s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  2h 11m | Avg:  4m 22s | Max: 14m 35s
  🟩 14                 Pass: 100%/34  | Total:  3h 27m | Avg:  6m 06s | Max: 34m 58s | Hits:  98%/4692  
  🟩 17                 Pass: 100%/33  | Total:  3h 08m | Avg:  5m 43s | Max: 20m 06s | Hits:  98%/3519  
  🟩 20                 Pass: 100%/21  | Total:  2h 30m | Avg:  7m 08s | Max: 33m 24s | Hits:  98%/2346

🟩 libcudacxx: Pass: 100%/112 | Total: 14h 56m | Avg: 8m 00s | Max: 26m 57s | Hits: 98%/16401

🟩 cpu
  🟩 amd64              Pass: 100%/104 | Total: 14h 13m | Avg:  8m 12s | Max: 26m 57s | Hits:  98%/16401 
  🟩 arm64              Pass: 100%/8   | Total: 42m 36s | Avg:  5m 19s | Max: 12m 09s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 35m | Avg:  6m 22s | Max: 15m 46s | Hits:  99%/2541  
  🟩 11.8               Pass: 100%/3   | Total: 30m 04s | Avg: 10m 01s | Max: 14m 05s
  🟩 12.5               Pass: 100%/94  | Total: 12h 50m | Avg:  8m 11s | Max: 26m 57s | Hits:  98%/13860 
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total: 34m 29s | Avg: 17m 14s | Max: 17m 39s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 35m | Avg:  6m 22s | Max: 15m 46s | Hits:  99%/2541  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 30m 04s | Avg: 10m 01s | Max: 14m 05s
  🟩 nvcc12.5           Pass: 100%/92  | Total: 12h 16m | Avg:  8m 00s | Max: 26m 57s | Hits:  98%/13860 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 34m 29s | Avg: 17m 14s | Max: 17m 39s
  🟩 nvcc               Pass: 100%/110 | Total: 14h 21m | Avg:  7m 50s | Max: 26m 57s | Hits:  98%/16401 
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 36m 19s | Avg:  6m 03s | Max: 15m 41s
  🟩 Clang10            Pass: 100%/3   | Total: 36m 14s | Avg: 12m 04s | Max: 15m 55s
  🟩 Clang11            Pass: 100%/4   | Total: 26m 54s | Avg:  6m 43s | Max: 14m 29s
  🟩 Clang12            Pass: 100%/4   | Total: 26m 46s | Avg:  6m 41s | Max: 14m 59s
  🟩 Clang13            Pass: 100%/4   | Total: 16m 01s | Avg:  4m 00s | Max:  5m 01s
  🟩 Clang14            Pass: 100%/4   | Total: 16m 34s | Avg:  4m 08s | Max:  4m 40s
  🟩 Clang15            Pass: 100%/4   | Total: 16m 54s | Avg:  4m 13s | Max:  4m 43s
  🟩 Clang16            Pass: 100%/4   | Total: 26m 40s | Avg:  6m 40s | Max: 14m 03s
  🟩 Clang17            Pass: 100%/14  | Total:  2h 38m | Avg: 11m 20s | Max: 25m 13s
  🟩 GCC6               Pass: 100%/2   | Total:  4m 55s | Avg:  2m 27s | Max:  2m 28s
  🟩 GCC7               Pass: 100%/6   | Total: 44m 22s | Avg:  7m 23s | Max: 14m 09s
  🟩 GCC8               Pass: 100%/6   | Total: 35m 00s | Avg:  5m 50s | Max: 11m 09s
  🟩 GCC9               Pass: 100%/6   | Total: 26m 36s | Avg:  4m 26s | Max: 11m 17s
  🟩 GCC10              Pass: 100%/4   | Total: 14m 15s | Avg:  3m 33s | Max:  4m 09s
  🟩 GCC11              Pass: 100%/7   | Total: 54m 55s | Avg:  7m 50s | Max: 14m 05s
  🟩 GCC12              Pass: 100%/4   | Total: 37m 10s | Avg:  9m 17s | Max: 15m 03s
  🟩 GCC13              Pass: 100%/21  | Total:  3h 32m | Avg: 10m 05s | Max: 26m 57s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 35m 03s | Avg: 11m 41s | Max: 15m 18s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 15m 46s | Avg: 15m 46s | Max: 15m 46s | Hits:  99%/2541  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 20m 23s | Avg: 10m 11s | Max: 10m 20s | Hits:  99%/5444  
  🟩 MSVC14.39          Pass: 100%/3   | Total: 34m 45s | Avg: 11m 35s | Max: 12m 41s | Hits:  98%/8416  
🟩 cxx_family
  🟩 Clang              Pass: 100%/47  | Total:  6h 01m | Avg:  7m 41s | Max: 25m 13s
  🟩 GCC                Pass: 100%/56  | Total:  7h 09m | Avg:  7m 39s | Max: 26m 57s
  🟩 Intel              Pass: 100%/3   | Total: 35m 03s | Avg: 11m 41s | Max: 15m 18s
  🟩 MSVC               Pass: 100%/6   | Total:  1h 10m | Avg: 11m 49s | Max: 15m 46s | Hits:  98%/16401 
🟩 gpu
  🟩 v100               Pass: 100%/112 | Total: 14h 56m | Avg:  8m 00s | Max: 26m 57s | Hits:  98%/16401 
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total: 10h 58m | Avg:  6m 38s | Max: 17m 39s | Hits:  98%/16401 
  🟩 NVRTC              Pass: 100%/4   | Total:  1h 35m | Avg: 23m 49s | Max: 26m 57s
  🟩 Test               Pass: 100%/8   | Total:  2h 20m | Avg: 17m 34s | Max: 25m 13s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  2m 07s | Avg:  2m 07s | Max:  2m 07s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 30m 04s | Avg: 10m 01s | Max: 14m 05s
  🟩 90a                Pass: 100%/4   | Total: 13m 37s | Avg:  3m 24s | Max:  3m 54s
🟩 std
  🟩 11                 Pass: 100%/29  | Total:  2h 48m | Avg:  5m 47s | Max: 20m 54s
  🟩 14                 Pass: 100%/32  | Total:  4h 13m | Avg:  7m 55s | Max: 20m 54s | Hits:  99%/7825  
  🟩 17                 Pass: 100%/31  | Total:  4h 55m | Avg:  9m 32s | Max: 26m 57s | Hits:  99%/5604  
  🟩 20                 Pass: 100%/19  | Total:  2h 56m | Avg:  9m 18s | Max: 26m 34s | Hits:  96%/2972

🟩 cudax: Pass: 100%/55 | Total: 2h 36m | Avg: 2m 51s | Max: 7m 37s | Hits: 44%/94

🟩 cpu
  🟩 amd64              Pass: 100%/51  | Total:  2h 26m | Avg:  2m 52s | Max:  7m 37s | Hits:  44%/94    
  🟩 arm64              Pass: 100%/4   | Total: 10m 09s | Avg:  2m 32s | Max:  2m 50s
🟩 ctk
  🟩 12.0               Pass: 100%/23  | Total:  1h 07m | Avg:  2m 55s | Max:  7m 31s | Hits:  44%/47    
  🟩 12.5               Pass: 100%/32  | Total:  1h 29m | Avg:  2m 48s | Max:  7m 37s | Hits:  44%/47    
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/23  | Total:  1h 07m | Avg:  2m 55s | Max:  7m 31s | Hits:  44%/47    
  🟩 nvcc12.5           Pass: 100%/32  | Total:  1h 29m | Avg:  2m 48s | Max:  7m 37s | Hits:  44%/47    
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/55  | Total:  2h 36m | Avg:  2m 51s | Max:  7m 37s | Hits:  44%/94    
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  4m 41s | Avg:  2m 20s | Max:  2m 27s
  🟩 Clang10            Pass: 100%/2   | Total:  4m 55s | Avg:  2m 27s | Max:  2m 30s
  🟩 Clang11            Pass: 100%/4   | Total:  9m 16s | Avg:  2m 19s | Max:  2m 28s
  🟩 Clang12            Pass: 100%/4   | Total:  9m 23s | Avg:  2m 20s | Max:  2m 31s
  🟩 Clang13            Pass: 100%/4   | Total:  9m 43s | Avg:  2m 25s | Max:  2m 36s
  🟩 Clang14            Pass: 100%/6   | Total: 19m 33s | Avg:  3m 15s | Max:  5m 46s
  🟩 Clang15            Pass: 100%/2   | Total:  4m 42s | Avg:  2m 21s | Max:  2m 21s
  🟩 Clang16            Pass: 100%/6   | Total: 19m 46s | Avg:  3m 17s | Max:  6m 06s
  🟩 GCC9               Pass: 100%/2   | Total:  4m 48s | Avg:  2m 24s | Max:  2m 26s
  🟩 GCC10              Pass: 100%/4   | Total:  8m 55s | Avg:  2m 13s | Max:  2m 23s
  🟩 GCC11              Pass: 100%/4   | Total:  9m 31s | Avg:  2m 22s | Max:  2m 40s
  🟩 GCC12              Pass: 100%/12  | Total: 33m 41s | Avg:  2m 48s | Max:  4m 14s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total:  2m 56s | Avg:  2m 56s | Max:  2m 56s
  🟩 MSVC14.36          Pass: 100%/1   | Total:  7m 31s | Avg:  7m 31s | Max:  7m 31s | Hits:  44%/47    
  🟩 MSVC14.39          Pass: 100%/1   | Total:  7m 37s | Avg:  7m 37s | Max:  7m 37s | Hits:  44%/47    
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  1h 21m | Avg:  2m 43s | Max:  6m 06s
  🟩 GCC                Pass: 100%/22  | Total: 56m 55s | Avg:  2m 35s | Max:  4m 14s
  🟩 Intel              Pass: 100%/1   | Total:  2m 56s | Avg:  2m 56s | Max:  2m 56s
  🟩 MSVC               Pass: 100%/2   | Total: 15m 08s | Avg:  7m 34s | Max:  7m 37s | Hits:  44%/94    
🟩 gpu
  🟩 v100               Pass: 100%/55  | Total:  2h 36m | Avg:  2m 51s | Max:  7m 37s | Hits:  44%/94    
🟩 jobs
  🟩 Build              Pass: 100%/47  | Total:  2h 02m | Avg:  2m 36s | Max:  7m 37s | Hits:  44%/94    
  🟩 Test               Pass: 100%/8   | Total: 34m 35s | Avg:  4m 19s | Max:  6m 06s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  1m 56s | Avg:  1m 56s | Max:  1m 56s
  🟩 90a                Pass: 100%/1   | Total:  1m 59s | Avg:  1m 59s | Max:  1m 59s
🟩 std
  🟩 17                 Pass: 100%/31  | Total:  1h 21m | Avg:  2m 36s | Max:  6m 06s
  🟩 20                 Pass: 100%/24  | Total:  1h 15m | Avg:  3m 09s | Max:  7m 37s | Hits:  44%/94

🟩 pycuda: Pass: 100%/1 | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
+/-	libcu++
	CUB
	Thrust
	CUDA Experimental
	pycuda

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	pycuda

🏃‍ Runner counts (total jobs: 417)

#	Runner
305	`linux-amd64-cpu16`
61	`linux-amd64-gpu-v100-latest-1`
28	`linux-arm64-cpu16`
23	`windows-amd64-cpu16`

It is proving difficult to handle for msvc and also the one we are using in libcu++ it much cleaner Gets NVIDIA#2160 compiling on MSVC

Rework mdspan concept emulation

a0d3d8c

It is proving difficult to handle for msvc and also the one we are using in libcu++ it much cleaner Gets NVIDIA#2160 compiling on MSVC

miscco requested review from a team as code owners August 9, 2024 11:47

miscco requested review from wmaxey, elstehle and ericniebler August 9, 2024 11:47

miscco added feature request New feature or request. libcu++ For all items related to libcu++ CUDA Next Feature intended for the Cuda Next experimental library labels Aug 9, 2024

miscco commented Aug 9, 2024

View reviewed changes

miscco enabled auto-merge (squash) August 9, 2024 13:53

miscco disabled auto-merge August 9, 2024 13:53

ericniebler approved these changes Aug 9, 2024

View reviewed changes

ericniebler merged commit 8e20c9a into NVIDIA:main Aug 9, 2024
433 checks passed

miscco deleted the cleanup_mdspan_concept_emulation branch August 9, 2024 15:16

pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Aug 20, 2024

Rework mdspan concept emulation (NVIDIA#2213)

4b364a1

It is proving difficult to handle for msvc and also the one we are using in libcu++ it much cleaner Gets NVIDIA#2160 compiling on MSVC

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework mdspan concept emulation #2213

Rework mdspan concept emulation #2213

miscco commented Aug 9, 2024

miscco Aug 9, 2024

ericniebler left a comment

github-actions bot commented Aug 9, 2024

🟩 cub: Pass: 100%/131 | Total: 21h 53m | Avg: 10m 01s | Max: 1h 02m | Hits: 99%/4254

🟩 thrust: Pass: 100%/118 | Total: 11h 17m | Avg: 5m 44s | Max: 34m 58s | Hits: 98%/10557

🟩 libcudacxx: Pass: 100%/112 | Total: 14h 56m | Avg: 8m 00s | Max: 26m 57s | Hits: 98%/16401

🟩 cudax: Pass: 100%/55 | Total: 2h 36m | Avg: 2m 51s | Max: 7m 37s | Hits: 44%/94

🟩 pycuda: Pass: 100%/1 | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 417)

Rework mdspan concept emulation #2213

Rework mdspan concept emulation #2213

Conversation

miscco commented Aug 9, 2024

miscco Aug 9, 2024

Choose a reason for hiding this comment

ericniebler left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 9, 2024

🟩 cub: Pass: 100%/131 | Total: 21h 53m | Avg: 10m 01s | Max: 1h 02m | Hits: 99%/4254

🟩 thrust: Pass: 100%/118 | Total: 11h 17m | Avg: 5m 44s | Max: 34m 58s | Hits: 98%/10557

🟩 libcudacxx: Pass: 100%/112 | Total: 14h 56m | Avg: 8m 00s | Max: 26m 57s | Hits: 98%/16401

🟩 cudax: Pass: 100%/55 | Total: 2h 36m | Avg: 2m 51s | Max: 7m 37s | Hits: 44%/94

🟩 pycuda: Pass: 100%/1 | Total: 11m 15s | Avg: 11m 15s | Max: 11m 15s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 417)