Enable additional arguments in build_common.sh #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
requested review from
jarmak-nv,
ericniebler and
jrhemstad
and removed request for
a team
wmaxey
changed the title
|
I have tested the extra options locally. The CCCL project is able to configure and build with a custom path to NVCC. |
miscco
approved these changes
Jul 18, 2023
jrhemstad
reviewed
Jul 18, 2023
| echo "The PARALLEL_LEVEL environment variable controls the amount of build parallelism. Default is the number of cores." | ||
| echo "Example: PARALLEL_LEVEL=8 $0 g++-8 14 \"70\" " | ||
| echo "Example: $0 clang++-8 17 \"70;75;80-virtual\" " | ||
| echo "Possible options: " | ||
| echo " -nvcc: path/to/nvcc" |
There was a problem hiding this comment.
What do you think about making this option more general and calling it --cuda_compiler to enable us to later set up clang-cuda builds?
There was a problem hiding this comment.
What do you think about making this option more general and calling it
--cuda_compilerto enable us to later set up clang-cuda builds?
I didn't do that only because there was some existing NVCC logic that comes later.
There was a problem hiding this comment.
Yeah, I guess we'll just cross that bridge when we get there.
jrhemstad
reviewed
Jul 18, 2023
jrhemstad
reviewed
Jul 18, 2023
| fi | ||
|
|
||
| # Begin processing unsets after option parsing | ||
| set -u |
jrhemstad
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #171
Allows passing options into build_[test].sh scripts.
Might be a little hacky.
Checklist