-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO_NOT_MERGE] disable system header escape hatch #2426
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
reviewed
Sep 18, 2024
@@ -79,9 +79,6 @@ function(thrust_add_test target_name_var test_name test_src thrust_target) | |||
target_compile_definitions(${test_target} PRIVATE THRUST_TEST_DEVICE_SIDE) | |||
endif() | |||
|
|||
# Ensure that we build our tests without treating ourself as system header | |||
target_compile_definitions(${test_target} PRIVATE "_CCCL_NO_SYSTEM_HEADER") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could actually drop this permanently, since we're linking the shared compiler interface targets in here.
/okay to test |
🟨 CI finished in 8h 35m: Pass: 97%/437 | Total: 12d 17h | Avg: 42m 00s | Max: 1h 51m | Hits: 33%/41645
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 437)
# | Runner |
---|---|
320 | linux-amd64-cpu16 |
66 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
miscco
force-pushed
the
test_system_header
branch
from
September 20, 2024 07:38
57af496
to
7f690c5
Compare
🟨 CI finished in 2h 28m: Pass: 99%/368 | Total: 8d 08h | Avg: 32m 39s | Max: 1h 27m | Hits: 23%/25655
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 368)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily disables the
_CCCL_NO_SYSTEM_HEADER
escape hatch due to nvbug4867473We need to establish how much is broken