Allow building CUB tests without cuRand #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
requested review from
alliepiper,
ericniebler and
elstehle
and removed request for
a team
miscco
approved these changes
Jul 21, 2023
cub/test/CMakeLists.txt
Outdated
Comment on lines
19
to
26
| find_package(CUDAToolkit) | ||
|
|
||
| set(curand_default OFF) | ||
| if (CUDAToolkit_FOUND) | ||
| set(curand_default ON) | ||
| endif() | ||
|
|
||
| option(CUB_C2H_ENABLE_CURAND "Use CUDA CURAND library" ${curand_default}) |
There was a problem hiding this comment.
Could that just be
Suggested change
| find_package(CUDAToolkit) | |
| set(curand_default OFF) | |
| if (CUDAToolkit_FOUND) | |
| set(curand_default ON) | |
| endif() | |
| option(CUB_C2H_ENABLE_CURAND "Use CUDA CURAND library" ${curand_default}) | |
| find_package(CUDAToolkit) | |
| option(CUB_C2H_ENABLE_CURAND "Use CUDA CURAND library" CUDAToolkit_FOUND) |
| float *generator_t::prepare_random_generator(seed_t seed, | ||
| std::size_t num_items) | ||
| { | ||
| m_distribution.resize(num_items); |
There was a problem hiding this comment.
Should this be
Suggested change
| m_distribution.resize(num_items); | |
| this->m_distribution.resize(num_items); |
elstehle
approved these changes
Jul 21, 2023
miscco
added
cub
wmaxey
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #249
This PR allows building CUB tests without cuRand. The cuRand usage is disabled by default if there's no CTK found. To force this behavior, one can provide
-DCUB_C2H_ENABLE_CURAND=NOCMake option.Checklist