Port cub::DeviceReduce tests to catch2 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elstehle
requested review from
gevtushenko and
miscco
and removed request for
a team
elstehle
added
cub
elstehle
changed the title
elstehle
commented
Jul 26, 2023
| /** | ||
| * Vector1 overloads | ||
| */ | ||
| #define CUB_VEC_1_TRAITS_OVERLOAD(T, BaseT) \ |
There was a problem hiding this comment.
I've migrated these from test_util.h to avoid having to rely on test_util.h. My ultimate goal is that, since test_util.h contains a lot of other old boilerplate testing code that were needed by old tests, to drop test_util.h altogether once the Catch2 migration is completed.
gevtushenko
approved these changes
Jul 26, 2023
| } | ||
|
|
||
| // TEST_TYPES == 5 | ||
| #elif TEST_TYPES == 5 |
There was a problem hiding this comment.
This approach is not very development-friendly. If you need different tests in different TUs, can we consider putting them into different source files?
There was a problem hiding this comment.
Agreed! Thanks for the suggestion. Moved the two test sections into their own translation unit:
device_reduce_iterators.cu: 64-bit indices and fancy iteratorsdevice_reduce_fp_inf.cu:Arg{Min,Max}withinf
Would be great if I could have your eyes do another pass over this refactor quickly 🙏
gevtushenko
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR partially addresses #85. It migrates tests for
DeviceReduce, i.e., single-problem reduction algorithms, to Catch2.Checklist