Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 23.08 devcontainers and CUDA 12.2 #270

Merged
merged 10 commits into from
Jul 28, 2023

Conversation

jrhemstad
Copy link
Collaborator

@jrhemstad jrhemstad commented Jul 26, 2023

Depends on #269

Description

closes #245

Updates to the 23.08 version of the devcontainers and likewise updates the newest CUDA version tested to 12.2.

Also removes old devcontainer.json for CUDA 12.1 and adds new ones for 12.2.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jrhemstad
Copy link
Collaborator Author

jrhemstad commented Jul 26, 2023

@senior-zero it looks like switching to CUDA 12.2 exposed one new build error with CUB + gcc12 + C++20. Could you take a look? https://github.com/NVIDIA/cccl/actions/runs/5673581483/job/15375399071#step:7:846

@gevtushenko
Copy link
Collaborator

@senior-zero it looks like switching to CUDA 12.2 exposed one new build error with CUB + gcc12 + C++20. Could you take a look? https://github.com/NVIDIA/cccl/actions/runs/5673581483/job/15375399071#step:7:846

@jrhemstad the issue is coming from nvbench (nvbug 4212889). I'll try to WAR the issue. Meanwhile we could disable building benchmarks to unblock this PR.

@gevtushenko gevtushenko mentioned this pull request Jul 27, 2023
2 tasks
@gevtushenko
Copy link
Collaborator

@jrhemstad workaround can be found here #275

@jrhemstad jrhemstad marked this pull request as ready for review July 27, 2023 16:34
@jrhemstad jrhemstad requested review from a team as code owners July 27, 2023 16:34
@jrhemstad jrhemstad requested review from jarmak-nv and elstehle and removed request for a team July 27, 2023 16:34
@jrhemstad jrhemstad merged commit 4922cbb into NVIDIA:main Jul 28, 2023
369 of 370 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Update to latest 23.08 devcontainers
3 participants