Update the README #291
Merged
Update the README #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
reviewed
Aug 1, 2023
jrhemstad
commented
Aug 7, 2023
|
I'd appreciate some fresh eyes on this since it's a lot of new content and I want to make sure I'm covering all the things users care about. Paging @bdice @kkraus14 @vyasr @leofang @cliffburdick |
cliffburdick
approved these changes
Sep 5, 2023
harrism
reviewed
Sep 5, 2023
bdice
reviewed
Sep 6, 2023
README.md
Outdated
| ### C++ Dialects | ||
| - C++11 (Deprecated in Thrust/CUB, to be removed in next major version) | ||
| - C++14 (Deprecated in Thrust/CUB, to be removed in next major version) | ||
| - C++17 |
There was a problem hiding this comment.
Trailing whitespace. Please trim the trailing whitespace in this file, there are other places where this is happening.
Suggested change
| - C++17 | |
| - C++17 |
|
|
||
| We encourage our users to adhere to the following guidelines in order to minimize the risk of disruptions from accidentally depending on parts of CCCL that we do not consider part of the public API: | ||
|
|
||
| - Do not add any declarations to the `thrust::`, `cub::`, `nv::`, or `cuda::` namespaces unless an exception is noted for a specific symbol, e.g., specializing a type trait. |
There was a problem hiding this comment.
Is this the first time that nv:: is mentioned? Is there context needed for that? (I don't actually know what's in that namespace.)
leofang
reviewed
Sep 6, 2023
| This means you cannot bring an older version of CCCL to a newer CTK. | ||
| In other words, **CCCL is never forwards compatible with the CUDA Toolkit.** | ||
|
|
||
| The table below summarizes compatibility of the CTK and CCCL: |
There was a problem hiding this comment.
Q: Do we have a table somewhere showing the version map from existing CTK 11.x, 12.x to CCCL versions? If so, perhaps we can link it here as a reference?
Co-authored-by: Mark Harris <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
gevtushenko
approved these changes
Sep 7, 2023
harrism
approved these changes
Sep 12, 2023
harrism
reviewed
Sep 13, 2023
|
LGTM so far! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #290 #66
Updates the main
README.mdto provide a comprehensive landing page for the new monorepo.Checklist