Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds catch2 tests for reduce-by-key #311

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Adds catch2 tests for reduce-by-key #311

merged 5 commits into from
Aug 10, 2023

Conversation

elstehle
Copy link
Collaborator

@elstehle elstehle commented Aug 9, 2023

Description

This PR partially addresses #85. It migrates tests for DeviceReduceByKey algorithms to Catch2.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@elstehle elstehle requested review from a team as code owners August 9, 2023 06:53
@elstehle elstehle requested review from gevtushenko and miscco and removed request for a team August 9, 2023 06:53
gevtushenko
gevtushenko approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor notes below.

cub/test/c2h/generators.cuh Outdated Show resolved Hide resolved
cub/test/c2h/generators.cuh Outdated Show resolved Hide resolved
cub/test/c2h/generators.cuh Outdated Show resolved Hide resolved
cub/test/catch2_test_device_reduce.cuh Outdated Show resolved Hide resolved
cub/test/catch2_test_device_reduce.cuh Outdated Show resolved Hide resolved
cub/test/catch2_test_device_reduce_by_key_iterators.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_reduce_by_key.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_reduce_by_key_iterators.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_reduce_by_key_iterators.cu Outdated Show resolved Hide resolved
@elstehle elstehle changed the title adds catch2 tests for reduce-by-key Adds catch2 tests for reduce-by-key Aug 9, 2023
@elstehle elstehle force-pushed the enh/catch2-device-reduce-by-key branch from fc31f84 to a88b19a Compare August 10, 2023 07:38
@elstehle elstehle merged commit 9f01569 into NVIDIA:main Aug 10, 2023
430 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gevtushenko gevtushenko gevtushenko approved these changes

@miscco miscco Awaiting requested review from miscco miscco is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elstehle @gevtushenko