Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Automation: add conditional steps due to context errors #353

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

jarmak-nv
Copy link
Collaborator

Description

closes #352

This PR adds an if check for each step in the Action. This way, we will never try to use a secret we don't have access to from the pull_request_review status preventing failures.

Still not sure why exit 0 behaves differently from all other exits.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jarmak-nv jarmak-nv added the bug Something isn't working right. label Aug 17, 2023
@jarmak-nv jarmak-nv requested review from a team as code owners August 17, 2023 14:02
@jarmak-nv jarmak-nv requested review from jrhemstad and alliepiper and removed request for a team August 17, 2023 14:02
@jrhemstad jrhemstad merged commit 020bfc4 into NVIDIA:main Aug 21, 2023
438 checks passed
@jarmak-nv jarmak-nv deleted the project-automation-exit-0-fix branch August 23, 2023 00:41
alliepiper pushed a commit to alliepiper/cccl that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Project Automation - Exit 0 in GHA doesn't end the workflow
3 participants