Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port cub::DeviceScanByKey tests to Catch2 #380

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Port cub::DeviceScanByKey tests to Catch2 #380

merged 4 commits into from
Sep 3, 2023

Conversation

elstehle
Copy link
Collaborator

Description

This PR addresses #85. It migrates tests for DeviceReduceByKey algorithms to Catch2.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@elstehle elstehle requested review from a team as code owners August 29, 2023 16:11
@elstehle elstehle requested review from gevtushenko and miscco and removed request for a team August 29, 2023 16:11
@elstehle elstehle added cub For all items related to CUB infrastructure Shared CMake, github, etc infrastructure labels Aug 29, 2023
gevtushenko
gevtushenko approved these changes Aug 30, 2023
View reviewed changes
cub/test/catch2_test_device_scan.cuh Outdated Show resolved Hide resolved
cub/test/catch2_test_device_scan_by_key_iterators.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_scan_by_key.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_scan_by_key.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_scan_by_key_iterators.cu Outdated Show resolved Hide resolved
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 1, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@elstehle elstehle force-pushed the enh/catch2-device-scan-by-key branch from f060998 to 4eabd27 Compare September 1, 2023 09:30
@elstehle elstehle merged commit eea703e into NVIDIA:main Sep 3, 2023
437 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gevtushenko gevtushenko gevtushenko approved these changes

@miscco miscco Awaiting requested review from miscco miscco is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
cub For all items related to CUB infrastructure Shared CMake, github, etc infrastructure
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elstehle @gevtushenko