Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Automation: set Roadmap project value on issue/pr close and Auto-type new issues #389

Merged

Conversation

jarmak-nv
Copy link
Collaborator

@jarmak-nv jarmak-nv commented Aug 30, 2023

Description

closes #388
closes #410

This PR creates two new GHAs

project_automation_roadmap_on_close.yml runs on Issues:Closed or Pull_Request_Target:Closed

The action:

  • Gets the project ID of the Issue/PR
  • Gets the current Roadmap value
    • This action assumes we maintain the current logic that the first Roadmap dropdown value is the upcoming release
  • Sets the Roadmap value to the current value

I've tested this in my local repo successfully.

project_automation_set_issue_type.yml runs on Issues:Opened

The action:

  • Uses a better way to find the Issues's project-specific ID than the other actions
    • Need to file a PR to update the existing ones, but low prio. Reason it's worth changing: the deeper you go into graphQL queries, the more it counts against rate limiting, so minimizing that is good
  • Finds the text between the brackets in the issue type
    • [BUG] there's some bug is extracted to BUG
  • Sets the Project Type field to the extracted value

This won't work if people don't use the templates/don't tag with brackets, but in most cases it should reduce another mouse-click.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jarmak-nv jarmak-nv requested review from a team as code owners August 30, 2023 21:15
@jarmak-nv jarmak-nv requested review from jrhemstad and miscco and removed request for a team August 30, 2023 21:15
@jarmak-nv jarmak-nv changed the title Create action to set Roadmap project value on issue/pr close Project Automation: set Roadmap project value on issue/pr close Aug 30, 2023
@jarmak-nv jarmak-nv marked this pull request as draft September 7, 2023 15:09
@jarmak-nv jarmak-nv changed the title Project Automation: set Roadmap project value on issue/pr close Project Automation: set Roadmap project value on issue/pr close and Auto-type new issues Sep 7, 2023
@jarmak-nv jarmak-nv marked this pull request as ready for review September 7, 2023 15:26
@jrhemstad jrhemstad merged commit c7eb05d into NVIDIA:main Sep 7, 2023
464 checks passed
@jarmak-nv jarmak-nv deleted the project-automation-roadmap-on-close branch November 28, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants