-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend thrust::complex
unit tests to prepare for upcoming replacement with std::complex
#413
Conversation
/ok to test |
df86b7d
to
42b79be
Compare
/ok to test |
6e092e7
to
fb378b0
Compare
To ensure a smooth transition from `thrust::complex` to `std::complex`, the unit tests are extended. This approach will prevent unintended constraints or extensions to `thrust::complex` functionality when the the actual switch is done. Key Enhancements: - Introduce type-promoting operator tests. - Generate distinct random values when multiple `thrust::complex` instances are used. - Apply clang-format.
fb378b0
to
8324bb4
Compare
/ok to add |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this PR only changes thrust::complex
tests. If this is intended, please, change PR name and description. Otherwise if the PR is still work in progress, please, convert it to draft.
That was me, I asked to first add the tests so that we know that we do not extend the existing API with tests and then put the changing commit on top |
thrust::complex
with a struct derived from std::complex
thrust::complex
unit tests to prepare for upcoming replacement with std::complex
Changed title and description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this looks great 🎉
I some minor nits and request for a few additional tests.
@senior-zero I see that we only test on host. We need to expand test coverage to device when we rework thrust test suite to catch2
/ok to test |
/ok to test |
To ensure a smooth transition from
thrust::complex
tostd::complex
,the unit tests are extended. This approach will prevent unintended
constraints or extensions to
thrust::complex
functionality when thethe actual switch is done.
Key Enhancements:
thrust::complex
instances are used.This PR is derived from #260 and has been rebased onto the current main branch
Checklist