Add support for tests that should fail at runtime #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is compilation must be successful, but running the test should return a non-zero exit code. This is useful for testing that code correctly asserts.
ahendriksen
requested review from
griwes and
miscco
and removed request for
a team
griwes
approved these changes
Sep 8, 2023
miscco
approved these changes
Sep 8, 2023
|
Thanks a lot, I am hard pressed to find a better name than runfail but this is awesome and will help a lot keeping the library sane 🎉 |
miscco
reviewed
Sep 8, 2023
| @@ -210,14 +217,18 @@ def _evaluate_pass_test(self, test, tmpBase, lit_config, | |||
| env) | |||
| report = "Compiled With: '%s'\n" % ' '.join(compile_cmd) | |||
| report += libcudacxx.util.makeReport(cmd, out, err, rc) | |||
| if rc == 0: | |||
| result_expected = (rc == 0) == run_should_pass | |||
There was a problem hiding this comment.
One day I will rewrite this as a switch over the number of possibilities but that day is not today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #417
Add support for tests that should fail at runtime
That is compilation must be successful, but running the test should return a non-zero exit code.
This is useful for testing that code correctly asserts.
Checklist