Add NVRTC_SKIP_KERNEL_RUN tag to compile, but skip running NVRTC test #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some kernels using TMA need some host code to run as well. In addition, they need the device symbols to be accessible from host code. This turns out to be quite difficult to achieve. Therefore, since the device code is already executed in the non-nvrtc tests, it is reasonable to allow a test to skip running device code when NVRTC is enabled. This still tests whether the code actually compiles.
ahendriksen
requested review from
ericniebler and
gevtushenko
and removed request for
a team
|
TODO: Once #379 is merged. The bulk tensor tests should be enabled for NVRTC again. libcudacxx/.upstream-tests/test/cuda/barrier/cp_async_bulk_tensor_{1,2..,5}d.pass.cpp |
gevtushenko
approved these changes
Sep 12, 2023
miscco
reviewed
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #433
This PR adds the NVRTC_SKIP_KERNEL_RUN tag that, if present in the source code of a test, changes how the test is executed under NVRTC. Specifically:
Checklist