-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CCCL_VERSION and script for updating version #652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
requested review from
alliepiper,
ericniebler,
jarmak-nv and
elstehle
and removed request for
a team
November 2, 2023 18:19
jrhemstad
added
the
backport branch/2.3.x
For backporting to the 2.3.x release branch
label
Nov 2, 2023
jrhemstad
commented
Nov 2, 2023
miscco
reviewed
Nov 2, 2023
@jrhemstad I forgot about this -- there is one place in CMake that encodes the version: |
miscco
reviewed
Nov 3, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__cccl/version.h
Outdated
Show resolved
Hide resolved
…on.h Co-authored-by: Michael Schellenberger Costa <[email protected]>
wmaxey
approved these changes
Nov 6, 2023
miscco
approved these changes
Nov 7, 2023
Successfully created backport PR for |
/backport |
Git push to origin failed for branch/2.3.x with exitcode 1 |
jrhemstad
removed
the
backport branch/2.3.x
For backporting to the 2.3.x release branch
label
Nov 8, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #646
closes #645
In attempt to add some consistency and convenience around our versioning, this PR introduces
CCCL_VERSION
definitions and a script for automating updating versions everywhere that it is needed.There's an unfortunate complication caused by the fact that Thrust/CUB use
MMMmmmpp
whereas libcudacxx usesMMMmmmppp
. I made the CCCL version useMMMmmmppp
. Ideally we'd have been able to defineTHRUST_VERSION
andCUB_VERSION
as:but this causes terrible macro expansion breakages due to the fact that
CUB_VERSION
is used with the preprocessor concatenation token,##
, to form the versioned inline namespace. Therefore, the CUB and Thrust versions need to remain as a singular value.<cuda/version>
andCCCL_VERSION
w/ associated componentsCCCL_VERSION
static_assert
s to ensure Thrust/CUB versions agree withCCCL_VERSION
update_version
script to automate updating versionsupdate_version
script to ensure this gets updatedChecklist