avoid unnecessary build context in 'make testprep' #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testprepbuilds some docker images to be used in this project's tests.Those images don't need any local files (i.e. their Dockefiles don't contain
COPYorADDstatements), so passing in the build context likedocker build -f Dockerfile .is unnecessary.This proposes instead switching them to no-context builds. That makes the builds slightly faster and their intention a bit clearer.
Notes for Reviewers
How I tested this
Ran the following.
On
main:On this branch:
That's not a huge difference, but this change would protect against other files accidentally left lying around in the repo from also being added to that build context unnecessarily.