Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support pair_contains in static_map and static_multimap #173

Closed
ttnghia opened this issue Jun 3, 2022 · 1 comment
Closed

[FEA] Support pair_contains in static_map and static_multimap #173

ttnghia opened this issue Jun 3, 2022 · 1 comment
Labels
helps: rapids Helps or needed by RAPIDS topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap type: feature request New feature request wontfix This will not be worked on

Comments

@ttnghia
Copy link

ttnghia commented Jun 3, 2022 •
edited by PointKernel
Loading

In static_multimap, there are various pair_* APIs but not pair_contains. Sometimes we need it for checking the existence of key/value pairs given from input iterators.

It's great to have such API added to static_multimap as well as static_map.
@ttnghia ttnghia mentioned this issue Jun 3, 2022
Merged
@PointKernel PointKernel added type: feature request New feature request topic: static_multimap Issue related to the static_multimap labels Jun 3, 2022
This was referenced Jun 3, 2022
Merged
Closed
@ttnghia ttnghia changed the title [FEA] Support pair_contains in static_multimap [FEA] Support pair_contains in static_map and static_multimap Jun 3, 2022
@ttnghia ttnghia changed the title [FEA] Support pair_contains in static_map and static_multimap [FEA] Support pair_contains in static_multimap Jun 3, 2022
@PointKernel PointKernel added helps: rapids Helps or needed by RAPIDS P1: Should have Necessary but not critical labels Jun 4, 2022
@PointKernel PointKernel mentioned this issue Jun 5, 2022
Merged
@ttnghia ttnghia mentioned this issue Jun 12, 2022
Closed
@PointKernel PointKernel changed the title [FEA] Support pair_contains in static_multimap [FEA] Support pair_contains in static_map and static_multimap Jun 13, 2022
@PointKernel PointKernel added the topic: static_map Issue related to the static_map label Jun 13, 2022
@ttnghia ttnghia mentioned this issue Jun 15, 2022
Closed
@PointKernel PointKernel mentioned this issue Jul 20, 2022
Closed
@PointKernel PointKernel added wontfix This will not be worked on and removed P1: Should have Necessary but not critical labels Jul 25, 2022
@PointKernel
Copy link
Member

Closing this since the functionality is no longer desired by using set contains.

rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Aug 17, 2022
@ttnghia
Fully support nested types in cudf::contains (#10656)
127d574 
This extends the `cudf::contains` API to support nested types (lists + structs) with arbitrarily nested levels. As such, `cudf::contains` will work with literally any type of input data.

In addition, this fixes null handling of `cudf::contains` with structs column + struct scalar input when the structs column contains null rows at the top level while the scalar key is valid but all nulls at children levels.

Closes: #8965
Depends on:
 * #10730
 * #10883
 * #10802
 * #10997
 * NVIDIA/cuCollections#172
 * NVIDIA/cuCollections#173
 * #11037
 * #11356

Authors:
  - Nghia Truong (https://github.com/ttnghia)
  - Devavret Makkar (https://github.com/devavret)
  - Bradley Dice (https://github.com/bdice)
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #10656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
helps: rapids Helps or needed by RAPIDS topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap type: feature request New feature request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pair_contains in single map PointKernel/cuCollections
2 participants
@ttnghia @PointKernel