Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: simpleVulkan now works on windows 10 #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Schabrackentapir
Copy link

Bugfix #1: added missing cudaExternalMemoryDedicated flag on cudaExternalMemoryHandleDesc
Bugfix #2: IsWindows8OrGreater queries return false on Windows 10. Always returning Windows 10 values now (might break on older Windows versions)

Bugfix NVIDIA#1:  added missing cudaExternalMemoryDedicated flag on cudaExternalMemoryHandleDesc
Bugfix NVIDIA#2:  IsWindows8<xxx>OrGreater queries return false on Windows 10. Always returning Windows 10 values now (might break on older Windows versions)
@Schabrackentapir
Copy link
Author

"simpleVulkan" at NVIDIA:master currently crashes at runtime on windows 10. With a very cryptic error message.
Bugfix #1 fixes this crash.
Bugfix #2 seems to be optional. Both <...>OPAQUE_WIN32_BIT and <...>OPAQUE_WIN32_KMT_BIT work on windows 10. At least on my system. I'm not sure why the code attempts to distinguish them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant