Pre-compile end-to-end gpu driver validation #91
Conversation
shivakunv
force-pushed
the
e2etestdriver
branch
8 times, most recently
from
3fe0f83
to
9c84eaf
Compare
shivakunv
force-pushed
the
e2etestdriver
branch
13 times, most recently
from
03e0cc4
to
2563c6f
Compare
shivakunv
force-pushed
the
e2etestdriver
branch
9 times, most recently
from
bbcbf64
to
f3aba06
Compare
|
@cdesiniotis PTAL |
There was a problem hiding this comment.
Added our comments during a peer-review.
For a follow-up, let's investigate how we can prevent the gitlab-master pipelines from publishing tags when the e2e tests fail. One idea is to push the tags initially to a staging location on ghcr.io, and only after the tests pass do we copy them over to a different location. The internal pipelines would be configured to pull the tags from the latter location.
shivakunv
force-pushed
the
e2etestdriver
branch
12 times, most recently
from
ed8ced1
to
55ef518
Compare
There was a problem hiding this comment.
@shivakunv thanks for the patience and work on this. I left a few more questions / comments. None of them are blocking and I am fine to address some cleanup / improvements in follow-ups. I definitely want to make the Github Action steps more readable / maintainable. It will also help us in the future when we want to start building precompiled images for other distributions, i.e. ubuntu24.04.
| driver_branch=$(echo "$driver_branch_json" | jq -r '.[]') | ||
|
|
||
| kernel_versions=() | ||
| for kernel_flavor in $kernel_flavors; do |
There was a problem hiding this comment.
I am okay if we do this in a follow-up, but I would like to clean this up a bit for readability. We should consider abstracting away as much of this as possible in a script that we can call from here. For example, we can simplify this entire code block to just:
source ./tests/scripts/ci-precompiled-helpers.sh
KERNEL_VERSIONS=$(get_kernel_versions_to_test $BASE_TARGET $DRIVER_BRANCHES $KERNEL_FLAVORS)
if [ -z "$KERNEL_VERSIONS" ]; then
exit
fi
# Convert array to JSON format and assign
echo "[]" > $GITHUB_WORKSPACE/matrix_values.json
printf '%s\n' "${KERNEL_VERSIONS[@]}" | jq -R . | jq -s . > $GITHUB_WORKSPACE/matrix_values.json
echo "matrix_values=$(cat $GITHUB_WORKSPACE/matrix_values.json | jq -c .)" >> $GITHUB_OUTPUT
echo "matrix_values_not_empty=1" >> $GITHUB_OUTPUT
We should make this extensible, so in the future we can reuse this script for different distributions, e.g. ubuntu24.04.
There was a problem hiding this comment.
noted, TODO added
| export DRIVER_BRANCH="${3}" | ||
| export DIST="${4}" | ||
|
|
||
| export REGCTL_VERSION=v0.4.7 |
There was a problem hiding this comment.
Can we use the latest regctl version?
Not blocking -- we may want to consider adding a separate step in any GH action that requires regctl. That way we can define / maintain the version of regctl at the top-level where the GH actions are defined.
There was a problem hiding this comment.
noted, TODO added
|
@cdesiniotis |
shivakunv
force-pushed
the
e2etestdriver
branch
from
55ef518
to
5e152f0
Compare
Signed-off-by: shiva kumar <[email protected]>
shivakunv
force-pushed
the
e2etestdriver
branch
from
5e152f0
to
333ebbc
Compare
No description provided.