add support for deferred tasks #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitsh
force-pushed
the
ds-defer
branch
3 times, most recently
from
ed0e929
to
9a61109
Compare
pkg/engine/deferrer.go
Outdated
| executor executor | ||
| queue *utils.ChronoQueue | ||
| next time.Time | ||
| timer *time.Timer |
There was a problem hiding this comment.
Instead of maintaining a timer and a queue independently, would it be possible to subsume the timer into the queue?
That is, can we have something similar to DelayingQueue which has an AddAfter function. This function will add the item to the queue after the delay has passed. The queue has a blocking get function that can be used to get the required objects at the correct time.
|
Can you please add an example YAML file that uses the new functionality? |
dmitsh
force-pushed
the
ds-defer
branch
3 times, most recently
from
90ee2d8
to
5510f7d
Compare
Signed-off-by: Dmitry Shmulevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows to submit deferred tasks from the code based of certain events and conditions.
For example, we want to kill a job 30 seconds after it started.
We don't know when the job is scheduled, but we have an informer.
Once the informer recognizes the job, it will submit a deferred "DeleteJob" task that will kick off in 30 seconds and delete the job.