Adding format_float kernel #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Mike Wilson <[email protected]>
Co-authored-by: Mike Wilson <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
…k-rapids-jni into thirtiseven-float_to_string
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
…k-rapids-jni into thirtiseven-float_to_string
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
…k-rapids-jni into float_to_string
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
hyperbolic2346
requested changes
Dec 13, 2023
src/main/cpp/src/CastStringJni.cpp
Outdated
| @@ -1,4 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2022-2023, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Remove duplication.
There was a problem hiding this comment.
Thanks, done. I didn't find those copyright issues when upmerging.
Co-authored-by: Mike Wilson <[email protected]> Co-authored-by: Nghia Truong <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
ttnghia
reviewed
Dec 14, 2023
ttnghia
reviewed
Dec 14, 2023
ttnghia
reviewed
Dec 14, 2023
ttnghia
reviewed
Dec 14, 2023
Co-authored-by: Nghia Truong <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
ttnghia
previously approved these changes
Dec 15, 2023
|
build |
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
|
cudf submodule is still not up to date. You should do a "reset" on the submodule. |
Signed-off-by: Haoyang Li <[email protected]>
ttnghia
previously approved these changes
Dec 15, 2023
hyperbolic2346
previously approved these changes
Dec 15, 2023
Co-authored-by: Mike Wilson <[email protected]>
thirtiseven
dismissed stale reviews from hyperbolic2346 and ttnghia
via
20415e7
|
build |
hyperbolic2346
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1508, please review it first.
This PR adds format_float kernel to support float case of
format_numberin spark-rapids.format_number(x,d)is used to format a number, adding a comma every 3 characters for the integer part, and keeping d digits for the decimal part, in half even rounding mode. i.e. 12345678.123456, 5 => 12,345,678.12346More contexts in NVIDIA/spark-rapids#9173
More tests in plugin PR: NVIDIA/spark-rapids#9790