Fix a bug in format_float kernel #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <[email protected]>
|
build |
mythrocks
reviewed
Jan 4, 2024
| bool const sign, | ||
| char* const result, | ||
| int digits) | ||
| __device__ inline int to_formated_double_chars(floating_decimal_64 const v, |
There was a problem hiding this comment.
Nit: Minor typo.
Suggested change
| __device__ inline int to_formated_double_chars(floating_decimal_64 const v, | |
| __device__ inline int to_formatted_double_chars(floating_decimal_64 const v, |
mythrocks
reviewed
Jan 4, 2024
| bool const sign, | ||
| char* const result, | ||
| int digits) | ||
| __device__ inline int to_formated_float_chars(floating_decimal_32 const v, |
There was a problem hiding this comment.
Nit:
Suggested change
| __device__ inline int to_formated_float_chars(floating_decimal_32 const v, | |
| __device__ inline int to_formatted_float_chars(floating_decimal_32 const v, |
mythrocks
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
I'm ok with this change, but we're going to have to address some minor stuff in this source file, at some point.
- It would be good to add some function-level docs to
to_formatted_float_chars,to_formatted_double_chars. - Is there commonality between
to_formatted_float_charsandto_formatted_double_chars? If we discount the difference of callingdecimalLength17anddecimalLength9, they look like this could be a single function template. (I haven't looked closely enough, maybe?) - Is
actural_roundsupposed to beactual_round?
We can address this later, in a follow-on.
|
Thanks for the review @mythrocks ! will address those later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_number(0.485362439659, 13)will get 1.8536243965900 in the plugin. It's a kernel bug.Current
round_half_evenwill handle trailing zeros, but it's unnecessary because it will be handled later anyway, and it will confuse the following logic which checks the length of the rounded number.Also add some minor refactoring and testing.