Disable large strings support in libcudf build #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
Verified that when rapidsai/cudf#16037 is added to the build, this change adds the appropriate compile-time flag for the libcudf build to prevent large strings support from being enabled by default. Also verified that this can be added before that cudf change, as it only generates a warning in the cmake build about an unused flag. |
|
build |
abellina
approved these changes
Jul 1, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2189. rapidsai/cudf#16037 is enabling large strings support by default in libcudf, but the RAPIDS Accelerator still has many places that assume offsets are always 4 bytes. Until #2190 is fixed, we will need to explicitly disable large strings support in the libcudf build.