Add HostTable interface to allow wielding of host tables in native code #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
ttnghia
reviewed
Sep 16, 2024
Comment on lines
+28
to
+38
| * @brief A non-owning, immutable view of host data as a column of elements, | ||
| * some of which may be null as indicated by a bitmask. | ||
| * | ||
| * Unless otherwise noted, the memory layout of the `host_column_view`'s data and | ||
| * bitmask is expected to adhere to the Arrow Physical Memory Layout | ||
| * Specification: https://arrow.apache.org/docs/memory_layout.html | ||
| * | ||
| * Because `host_column_view` is non-owning, no host memory is allocated nor freed | ||
| * when `host_column_view` objects are created or destroyed. | ||
| */ | ||
| class host_column_view { |
There was a problem hiding this comment.
I see that this class has almost identical members as cudf::column_view. So, given a host data buffer as a column of elements, we should be able to construct an instance of cudf::column_view out of it. We just need to keep track that the created instance is viewing host data, and this can be done in Java through a boolean flag.
Did I miss anything here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends upon rapidsai/cudf#16784.
Adds a host version of cudf::table_view and cudf::column_view so we can examine and construct tables in host memory, along with APIs to construct a contiguous device table from a host table. This makes it easier to move some host processing code from Java into native code to avoid excessive object creation for very wide and/or deeply nested table schemas.