Make strip optional for castToInteger and castToDecimal #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
jlowe
previously approved these changes
Dec 5, 2022
|
CI failed because of an spdlog issue that I think is unrelated. Looking into it... |
|
Looks like the spdlog issue is related to a change to RMM. rapidsai/rmm#1173 (comment) and because CUDF pulls in the latest RMM and we have not fixed NVIDIA/spark-rapids#6445 yet so we let CUDF pull in the latest RMM, which makes our builds not reproducible, we are failing yet again. |
hyperbolic2346
previously approved these changes
Dec 5, 2022
mythrocks
previously approved these changes
Dec 5, 2022
|
build |
revans2
dismissed stale reviews from mythrocks, hyperbolic2346, and jlowe
via
df41cb9
|
build |
|
@jlowe @hyperbolic2346 @mythrocks could you all take another look. I forgot to update the C++ tests, which should be fixed now. |
jlowe
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive parsing does not strip out leading or trailing white space (for integer and decimal types, float it does because java does it for them).
This makes that stripping optional so we can reuse the existing kernels with hive parsing.