Skip to content

Commit

Permalink
Add support to Python3.11 (#1105)
Browse files Browse the repository at this point in the history
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Contributes to #1071

- Fix a bug that caused the CLI to fail with python-3.11
- Change compatibility of python packages in toml files
- tested the build.sh cmd
  • Loading branch information
amahussein authored Jun 11, 2024
1 parent 7699d3c commit b232f1f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10']
python-version: ['3.8', '3.9', '3.10', '3.11']

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion user_tools/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies = [
"tabulate==0.8.10",
"importlib-resources==5.10.2",
"requests==2.31.0",
"packaging==23.0",
"packaging>=23.0",
"certifi==2023.7.22",
"idna==3.4",
"urllib3==1.26.14",
Expand Down
2 changes: 1 addition & 1 deletion user_tools/src/spark_rapids_pytools/cloud_api/sp_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ def get_matching_executor_instance(self, cores_per_executor):
def generate_cluster_configuration(self, render_args: dict):
if not self.cluster_inference_supported:
return None
template_path = Utils.resource_path(f'templates/cluster_template/{self.type_id}.ms')
template_path = Utils.resource_path(f'templates/cluster_template/{CspEnv.pretty_print(self.type_id)}.ms')
return TemplateGenerator.render_template_file(template_path, render_args)


Expand Down
3 changes: 2 additions & 1 deletion user_tools/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

[tox]
envlist =
python{3.8,3.9,3.10}
python{3.8,3.9,3.10,3.11}
coverage
pylint
flake8
Expand All @@ -16,6 +16,7 @@ python =
3.8: python3.8, pylint, flake8
3.9: python3.9, pylint, flake8
3.10: python3.10, pylint, flake8
3.11: python3.11, pylint, flake8

[testenv]
deps =
Expand Down

0 comments on commit b232f1f

Please sign in to comment.