Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add support to MaxBy and MinBy in Qualification tool #1329

Closed
2 tasks
amahussein opened this issue Sep 3, 2024 · 0 comments · Fixed by #1335
Closed
2 tasks

[FEA] Add support to MaxBy and MinBy in Qualification tool #1329

amahussein opened this issue Sep 3, 2024 · 0 comments · Fixed by #1335
Assignees
@amahussein
Labels
core_tools Scope the core module (scala) feature request New feature or request

Comments

@amahussein
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

With later sync-up with plugin supported ops (#1328), new operators were added that need to be marked as supported

  • MaxBy
  • MinBy

Additional context

NVIDIA/spark-rapids@dbd92d2
@amahussein amahussein added ? - Needs Triage feature request New feature or request core_tools Scope the core module (scala) and removed ? - Needs Triage labels Sep 3, 2024
@amahussein amahussein self-assigned this Sep 6, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Sep 6, 2024
@amahussein
Add support to MaxBy and MinBy in Qualification tool
c0cfe1d 
Signed-off-by: Ahmed Hussein <[email protected]>

Fixes NVIDIA#1329

- Add `MaxBy` and `MinBy` to the supported expressions CSV files
- Update the score sheets
- Remove the override from the `override_supported_configs.json`
- Add a unit test to verify that `min_by` and `max_by` are marked as
  supported when appearing in hashAggregate
@amahussein amahussein mentioned this issue Sep 6, 2024
Merged
amahussein added a commit that referenced this issue Sep 6, 2024
@amahussein
Add support to MaxBy and MinBy in Qualification tool (#1335)
12adc3f 
Signed-off-by: Ahmed Hussein <[email protected]>

Fixes #1329

- Add `MaxBy` and `MinBy` to the supported expressions CSV files
- Update the score sheets
- Remove the override from the `override_supported_configs.json`
- Add a unit test to verify that `min_by` and `max_by` are marked as
  supported when appearing in hashAggregate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support to MaxBy and MinBy in Qualification tool amahussein/spark-rapids-tools
1 participant
@amahussein