Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add ExistenceJoin to supported joinType #400

Closed
nartal1 opened this issue Jun 29, 2023 · 1 comment · Fixed by #432
Closed

[BUG] Add ExistenceJoin to supported joinType #400

nartal1 opened this issue Jun 29, 2023 · 1 comment · Fixed by #432
Assignees
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@nartal1
Copy link
Collaborator

nartal1 commented Jun 29, 2023

Describe the bug
SortMergeJoinExec and BroadcastHashJoinExec is shown as Unsupported Execs where the joinType is ExistenceJoin. We currently support ExistenceJoin - NVIDIA/spark-rapids#589 .

Expected behavior
JoinExecs should not be classified as unsupported execs if jointype is ExistenceJoin.

Environment details (please complete the following information)
OnPrem, all CSP's

@nartal1 nartal1 added bug Something isn't working ? - Needs Triage labels Jun 29, 2023
@amahussein amahussein added the core_tools Scope the core module (scala) label Jun 30, 2023
@amahussein
Copy link
Collaborator

amahussein commented Jul 5, 2023

It is interesting to see that ExistenceJoin has been supported for over 18-months while the tools is not synced-up.
IMHO, we need to introduce a process similar to "spark audit" in which commits added into the RAPIDS plugin is processed.

There are some other questions that need to be answered:

  • Going backward to review any missed features in the plugin and opportunities to improve profiling and recommendations.
  • Rethink how filing new features can better integrates with "Tools". In that scenario, "Tools" is part of the story/design of the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants