Qualification tool: Add ExistenceJoin to supported jointype #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
nartal1
added
bug
amahussein
reviewed
Jul 12, 2023
There was a problem hiding this comment.
Thanks @nartal1
Just in case, We need to verify that the test runs against different spark versions.
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
Outdated
Show resolved
Hide resolved
amahussein
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Thanks @nartal1 for the fix.
Is there a query that could be used for a unit test?
I see some occurrences in the integration-tests https://github.com/NVIDIA/spark-rapids/blob/branch-23.08/integration_tests/src/main/python/join_test.py#L830
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #400
This PR adds ExistenceJoin as supported jointype while qualifying apps. Tested it on eventlogs used for integration tests and the joins mentioned in the issue are no longer in unsupported execs.
Once this PR is merged we should updated expected_results for integration tests. We should hold off merging this until we know the steps to generate new results.