Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] profiling command should run without cluster-info #436

Closed
Tracked by #371
amahussein opened this issue Jul 13, 2023 · 0 comments · Fixed by #426
Closed
Tracked by #371

[FEA] profiling command should run without cluster-info #436

amahussein opened this issue Jul 13, 2023 · 0 comments · Fixed by #426
Assignees
@amahussein
Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@amahussein
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Allow the user to run profiling without worker_info and then not execute auto-tuner and just generate profiling output files locally.
That would be needed to fully deprecate Profiler java command as some customers have run w/o cluster info to get metrics output without recommendations.

Additional context
@amahussein amahussein added feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python) ? - Needs Triage labels Jul 13, 2023
@amahussein amahussein self-assigned this Jul 13, 2023
@amahussein amahussein mentioned this issue Jul 13, 2023
Closed
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Jul 13, 2023
@amahussein
Profiling command should run without cluster-info
2273f19 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#436

Allow the user to run profiling without worker_info and then not execute
auto-tuner and just generate profiling output
This implies that users can use the python wrapper deprecating the java
cmd
@amahussein amahussein mentioned this issue Jul 13, 2023
Merged
amahussein added a commit that referenced this issue Jul 13, 2023
@amahussein
Add ascli as a new simplified tools command (#426)
df223e1 
* Add ascli as a new simplified qualification command

Fixes #425

- adds a new `ascli qualification` cmd
- platform default value is onPrem
- the platform is not yet detected from the eventlogs path

* Add ascli as a new simplified profiling command

- adds a new `ascli profiling` cmd
- platform default value is onPrem
- the platform is not yet detected from the eventlogs path
- todo: detect whether cluster is a CSP properties or worker's info
  custome file

* Update fire-dependency to BTE 0.5.0
* Profiling command should run without cluster-info

Fixes #436

Allow the user to run profiling without worker_info and then not execute
auto-tuner and just generate profiling output
This implies that users can use the python wrapper deprecating the java
cmd

---------

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
@amahussein amahussein mentioned this issue Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
1 participant
@amahussein