-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Databricks-AWS Qual tool to cache and process pricing info from DB website #1141
Refactor Databricks-AWS Qual tool to cache and process pricing info from DB website #1141
Conversation
Signed-off-by: cindyyuanjiang <[email protected]>
Signed-off-by: cindyyuanjiang <[email protected]>
Signed-off-by: cindyyuanjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang !
That's good that we have finally a catalog file to use for databricks.
Have you tested the fat-mode build? We need to make sure that these changes work fine when the tools are running offline.
@@ -0,0 +1,71 @@ | |||
# Copyright (c) 2023, NVIDIA CORPORATION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024 copyrights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks!
Signed-off-by: cindyyuanjiang <[email protected]>
Thanks @amahussein! Tested the fat-mode build successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @cindyyuanjiang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cindyyuanjiang
General comment on styling: we are trying to enforce defining the return type of each function as much as possible.
This is going to hunt us back with pylint moving forward which will cause the code to fail all pylint checks. For function returning nothing, then it is recommended to define it as def foo() -> None:
Signed-off-by: cindyyuanjiang <[email protected]>
Thanks @amahussein! Updated function return types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang !
LGTME
Fixes #1139.
Changes
DatabricksAWSPriceProvider
to cache and use pricing info from DB official website instead of outdated static filedatabricks-premium-catalog.json
file under resourcesTesting
spark_rapids qualification --eventlogs <my-event-logs> --platform databricks-aws --cluster <my-cluster-props>
Run the cmd above and confirm the pricing calculation is the same before and after this PR.