-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin mechanism for dataset-specific preprocessing in qualx #1148
Conversation
Signed-off-by: Lee Yang <[email protected]>
Signed-off-by: Lee Yang <[email protected]>
Signed-off-by: Lee Yang <[email protected]>
Signed-off-by: Lee Yang <[email protected]>
|
Yes, I recently tested |
Signed-off-by: Lee Yang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with the context to approve the PR.
Perhaps let's wait for @mattahrens' review.
@leewyang is this blocking you in anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR adds a plugin mechanism to invoke dataset-specific code to modify the pandas dataframe returned by the qualx
load_profiles()
function. This is intended to allow custom handlers for one-off cases which shouldn't be introduced into the main codebase.The path to the plugin module should be specified within the dataset JSON file with the "load_profiles_hook" key, e.g.
The plugin module should define a function with the following signature:
Changes
load_profiles_hook
.--output-sql-ids-aligned
argument to Profiler invocations (for future use).Test
Following CMDs have been tested:
Internal Usage: